Return-Path: Message-ID: <52B7FE0A.7000009@huawei.com> Date: Mon, 23 Dec 2013 17:10:34 +0800 From: Ding Tianhong MIME-Version: 1.0 References: <52B7C5C5.2050304@huawei.com> <52B7F853.8050806@meshcoding.com> <1387789163.22671.62.camel@joe-AO722> In-Reply-To: <1387789163.22671.62.camel@joe-AO722> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [B.A.T.M.A.N.] [PATCH 09/21] batman-adv: slight optimization of addr compare Reply-To: The list for a Better Approach To Mobile Ad-hoc Networking List-Id: The list for a Better Approach To Mobile Ad-hoc Networking List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Joe Perches , Antonio Quartulli Cc: Marek Lindner , Netdev , b.a.t.m.a.n@lists.open-mesh.org, "linux-kernel@vger.kernel.org" , "David S. Miller" On 2013/12/23 16:59, Joe Perches wrote: > On Mon, 2013-12-23 at 09:46 +0100, Antonio Quartulli wrote: >> On 23/12/13 06:10, Ding Tianhong wrote: >> >> [...] >> >>> --- a/net/batman-adv/originator.c >>> +++ b/net/batman-adv/originator.c >>> @@ -41,7 +41,7 @@ int batadv_compare_orig(const struct hlist_node *node, const void *data2) >>> const void *data1 = container_of(node, struct batadv_orig_node, >>> hash_entry); >>> >>> - return (memcmp(data1, data2, ETH_ALEN) == 0 ? 1 : 0); >>> + return ether_addr_equal_unaligned(data1, data2) ? 1 : 0; >> >> ether_addr_equal_unaligned() returns a bool value which is implicitly >> converted to 1 or 0: there is no need for the ternary if anymore. > > Should these use batadv_compare_eth? > > Yes, and need to remove the checks for return value. Regards Ding > >