From: "flichtenheld (Code Review)"
Date: Wed, 26 Jun 2024 09:25:01 +0000
In-Reply-To:
References:
Reply-To: frank@...2641..., arne-openvpn@...1227..., samuli@...515...,
openvpn-devel@lists.sourceforge.net
Message-ID: <52ac548ef240f1a606f584eabfe30c7a216ab7da-EmailReviewComments-HTML@...2715...>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Content-Type: multipart/alternative; boundary="ysmtWwrUrtk="; charset=UTF-8
Subject: [Openvpn-devel] [M] Change in openvpn[master]: t_server_null:
multiple improvements and fixes
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
To: mattock
Cc: plaisthos , openvpn-devel
--ysmtWwrUrtk=
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: mattock, plaisthos.
flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne=
t/c/openvpn/+/669?usp=3Demail )
Change subject: t_server_null: multiple improvements and fixes
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
Patchset:
PS3:
Still need to fix nbsd81 build. Otherwise looks good to me.
File doc/t_server_null.rst:
http://gerrit.openvpn.net/c/openvpn/+/669/comment/0f4fbfc2_5a621e23 :
PS2, Line 50: permit persist keepenv :wheel
> doesn't contain "nopass" ?
Done
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/669?usp=3Demail
To unsubscribe, or for help writing mail filters, visit http://gerrit.openv=
pn.net/settings
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2cce8ad4e0d262e1404ab1eb6ff673d8590b6b3a
Gerrit-Change-Number: 669
Gerrit-PatchSet: 3
Gerrit-Owner: mattock
Gerrit-Reviewer: flichtenheld
Gerrit-Reviewer: plaisthos
Gerrit-CC: openvpn-devel
Gerrit-Attention: plaisthos
Gerrit-Attention: mattock
Gerrit-Comment-Date: Wed, 26 Jun 2024 09:25:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: flichtenheld
Gerrit-MessageType: comment
--ysmtWwrUrtk=
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Attention is currently required from: mattock, plaisthos.
Patch set 3:Code-Review -1=
Vi=
ew Change
2 comments:
Done
To view, visit =
change 66=
9. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2cce8ad4e0d262e1404ab1eb6ff=
673d8590b6b3a
Gerrit-Change-Number: 669
Gerrit-PatchSet: 3
Gerrit-Owner: mattock <samuli@...515...>=
Gerrit-Reviewer: flichtenheld <frank@...2716...=
1...>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...=
.1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...=
ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...=
..1227...>
Gerrit-Attention: mattock <samuli@...515...=
>
Gerrit-Comment-Date: Wed, 26 Jun 2024 09:25:01=
+0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: flichtenheld <frank@...1186...=
.2641...>
Gerrit-MessageType: comment
--ysmtWwrUrtk=--