From: "flichtenheld (Code Review)" Date: Fri, 27 Dec 2024 15:46:02 +0000 In-Reply-To: References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <52c770d6cb92d2306b34fdcda73911e475f60cb6-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="Hi5Fv2Lg7QY="; charset=UTF-8 Subject: [Openvpn-devel] [S] Change in openvpn[master]: Rename aead-tag-at-end to aead-epoch List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --Hi5Fv2Lg7QY= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.ne= t/c/openvpn/+/805?usp=3Demail ) Change subject: Rename aead-tag-at-end to aead-epoch ...................................................................... Patch Set 8: Code-Review-1 (2 comments) Commit Message: http://gerrit.openvpn.net/c/openvpn/+/805/comment/2441bc09_930b0af9 : PS8, Line 8: maybe add a short explanation like: "We combine several data-format changes= into one flag since they will be introduced together and so we do not need= to separate them." File src/openvpn/crypto.h: http://gerrit.openvpn.net/c/openvpn/+/805/comment/7b1afc57_7cafb3b5 : PS8, Line 373: * AEAD tag is at the end of the packet and using epoch Remove "at", remove additional space before "packet". The sentence is still= not great then, but at least superficially correct. Maybe simpler: "Bit-flag indicating that the AEAD tag is at the end of the packet and epoc= h keys are used" -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/805?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9e9433b56dcbaa538d9bed30e50cf74948c647cc Gerrit-Change-Number: 805 Gerrit-PatchSet: 8 Gerrit-Owner: plaisthos Gerrit-Reviewer: flichtenheld Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Comment-Date: Fri, 27 Dec 2024 15:46:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --Hi5Fv2Lg7QY= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

Patch set 8:Code-Review -1=

Vi= ew Change

2 comments:

  • Commit Message:

    • Patch Set #8, Line 8:

      maybe add a short explanation like: &quo= t;We combine several data-format changes into one flag since they will be i= ntroduced together and so we do not need to separate them."

    • File src/openvpn/crypto.h:<= /p>

      • Patch Set #8, Line = 373: * AEAD tag is= at the end of the packet and using epoch

        Remove "at", remove addition= al space before "packet". The sentence is still not great then, b= ut at least superficially correct. Maybe simpler:
        "Bit-flag indicat= ing that the AEAD tag is at the end of the packet and epoch keys are used&q= uot;

    To view, visit change 805. To unsubscribe, or for= help writing mail filters, visit settings.

    Gerrit-Project: openvpn
    Gerrit-Branch: master
    Gerrit-Change-Id: I9e9433b56dcbaa538d9bed30e50= cf74948c647cc
    Gerrit-Change-Number: 805
    Gerrit-PatchSet: 8
    Gerrit-Owner: plaisthos <arne-openvpn@...1711...= 27...>
    Gerrit-Reviewer: flichtenheld <frank@...2716...= 1...>
    Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
    Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
    Gerrit-Comment-Date: Fri, 27 Dec 2024 15:46:02= +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment
    --Hi5Fv2Lg7QY=--