Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mail.openembedded.org (Postfix) with ESMTP id 73F0E616E0 for ; Tue, 25 Feb 2020 23:12:40 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Feb 2020 15:12:41 -0800 X-IronPort-AV: E=Sophos;i="5.70,485,1574150400"; d="scan'208,217";a="231188500" Received: from unknown (HELO [10.241.225.146]) ([10.241.225.146]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Feb 2020 15:12:40 -0800 From: Tim Orling Message-Id: <530098E8-9036-4FCC-AA97-34324C8ACA84@linux.intel.com> Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Date: Tue, 25 Feb 2020 15:12:40 -0800 In-Reply-To: To: Alexander Kanavin References: <20200225212233.30114-1-timothy.t.orling@linux.intel.com> X-Mailer: Apple Mail (2.3608.60.0.2.5) Cc: OE-core Subject: Re: [PATCH] libmodule-build-perl: upgrade 0.4229 -> 0.4231 X-BeenThere: openembedded-core@lists.openembedded.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Patches and discussions about the oe-core layer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Feb 2020 23:12:40 -0000 Content-Type: multipart/alternative; boundary="Apple-Mail=_DC2C6D09-7FE3-4242-97B2-9C73624E0489" --Apple-Mail=_DC2C6D09-7FE3-4242-97B2-9C73624E0489 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Somehow I totally missed this when sending the patch (obviously). Sigh. I=E2=80=99m on the fence about patch versus sed. I=E2=80=99m inclined to = stop mucking about=E2=80=A6 Thank you for the catch! > On Feb 25, 2020, at 2:00 PM, Alexander Kanavin = wrote: >=20 > But probably a better solution would be to keep the patch, and drop = the custom sed hack! >=20 > Alex >=20 > On Tue, 25 Feb 2020 at 22:58, Alexander Kanavin = > wrote: > On Tue, 25 Feb 2020 at 22:30, Tim Orling = > wrote: > + file://ptest-perl/run-ptest \ > + file://0001-Committing-changes-from-do_patch.patch \ >=20 > These two are 'devtool upgrade' noise, and should be removed. The = recipe does weird things which triggers devtool to add items = unnecessarily. >=20 > Alex --Apple-Mail=_DC2C6D09-7FE3-4242-97B2-9C73624E0489 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8 Somehow I totally missed this when sending the patch = (obviously). Sigh.

I=E2=80=99m on the fence about patch versus sed. I=E2=80=99m = inclined to stop mucking about=E2=80=A6

Thank you for the catch!

On Feb 25, 2020, at 2:00 PM, Alexander Kanavin <alex.kanavin@gmail.com> wrote:

But probably a better solution would be to = keep the patch, and drop the custom sed hack!

Alex

On Tue, 25 Feb 2020 at 22:58, Alexander Kanavin = <alex.kanavin@gmail.com> wrote:
On Tue, 25 = Feb 2020 at 22:30, Tim Orling <timothy.t.orling@linux.intel.com> wrote:
+          =  file://ptest-perl/run-ptest \
+           file://0001-Committing-changes-from-do_patch.patch = \

These = two are 'devtool upgrade' noise, and should be removed. The recipe does = weird things which triggers devtool to add items unnecessarily.

Alex

= --Apple-Mail=_DC2C6D09-7FE3-4242-97B2-9C73624E0489--