Return-Path: Message-ID: <5307692B.4070005@hurleysoftware.com> Date: Fri, 21 Feb 2014 09:56:43 -0500 From: Peter Hurley MIME-Version: 1.0 To: Hannes Reinecke , Josh Boyer , Greg Kroah-Hartman CC: "Linux-Kernel@Vger. Kernel. Org" , "stable@vger.kernel.org" , Lennart Poettering , Kay Sievers , Jiri Slaby , David Herrmann , Werner Fink , Ray Strode Subject: Re: [PATCH 3.13 35/99] tty: Set correct tty name in active sysfs attribute References: <20140220235118.191692546@linuxfoundation.org> <20140220235119.236520201@linuxfoundation.org> <5307683C.50209@suse.de> In-Reply-To: <5307683C.50209@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 02/21/2014 09:52 AM, Hannes Reinecke wrote: > On 02/21/2014 03:48 PM, Josh Boyer wrote: >> On Thu, Feb 20, 2014 at 6:52 PM, Greg Kroah-Hartman >> wrote: >>> 3.13-stable review patch. If anyone has any objections, please let me know. >>> >>> ------------------ >>> >>> From: Hannes Reinecke >>> >>> commit d8a5dc3033af2fd6d16030d2ee4fbd073460fe54 upstream. >>> >>> The 'active' sysfs attribute should refer to the currently active tty >>> devices the console is running on, not the currently active console. >>> >>> The console structure doesn't refer to any device in sysfs, only the tty >>> the console is running on has. So we need to print out the tty names in >>> 'active', not the console names. >>> >>> This resolves an issue on s390 platforms in determining the correct >>> console device to use. >> >> Just to be double sure this is seen, Ray points out that it breaks >> current plymouth because the heuristic changed. Hold off on this one? >> > Without this patch systemd won't present a login console for s390. > I'd prefer fixing plymouth. Not an option. As I said before, the old interface should be left alone and forked to present a new interface that systemd can use to get what it expects. Regards, Peter Hurley