From: Daniel Borkmann Date: Mon, 24 Feb 2014 14:06:02 +0000 Subject: Re: [PATCH net-next] loopback: sctp: add NETIF_F_SCTP_CSUM to device features Message-Id: <530B51CA.3090606@redhat.com> List-Id: References: <1393074113-9922-1-git-send-email-dborkman@redhat.com> <063D6719AE5E284EB5DD2968C1650D6D0F6C96DE@AcuExch.aculab.com> <530B1F93.4010308@redhat.com> <063D6719AE5E284EB5DD2968C1650D6D0F6C9802@AcuExch.aculab.com> <530B34D3.2050307@redhat.com> <063D6719AE5E284EB5DD2968C1650D6D0F6C99F9@AcuExch.aculab.com> In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D0F6C99F9@AcuExch.aculab.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: David Laight Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , "linux-sctp@vger.kernel.org" On 02/24/2014 02:24 PM, David Laight wrote: ... > Maybe the _le has something to do with it. > Could it be bit-reversing the crc and data bytes all the time? > The packet will (one would hope) want the crc in the same bit-order > as the data, so no bit reversal is needed - just the correct logic > and lookup table. Although it's a bit off-topic for this patch, but I'll have a look into __crc32c_le(); maybe something is just wrong with that code.