From: Fabio Estevam Date: Wed, 10 Jun 2009 07:17:27 -0700 (PDT) Subject: [U-Boot] [PATCH v3 5/6] MX31: Add basic support for Freescale i.MX31 PDK board. Message-ID: <531773.91622.qm@web51001.mail.re2.yahoo.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Wolfgang, --- On Tue, 6/9/09, Wolfgang Denk wrote: > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -527,6 +527,10 @@ Thomas Elste > >? > >? ??? modnet50??? > ARM720T (NET+50) > >? > > +Fabio Estevam > > + > > +??? mx31pdk??? > ??? i.MX31 > > + > >? Peter Figuli > > Is this correct? It's quite unusal that somebody? > becomes? maintainer > of? a? port? who? seems to have not > been involved with it at all - at > least I cannot see his name in any of the Signed-off-by > lines nor? in > any (C) lines or anywhere else? > > Fabio, do you agree? Magnus told me off the list that he has no interest in becoming the board maintainer and asked me if I could be the maintainer for the MX31PDK. We have been working on the MX31PDK U-boot port for quite some time. If you prefer to assign someone else, that's no problem for me. > ... > > +int board_init(void) > > +{ > > +??? /* CS5: CPLD incl. network > controller */ > > +??? __REG(CSCR_U(5)) = 0x0000d843; > > +??? __REG(CSCR_L(5)) = 0x22252521; > > +??? __REG(CSCR_A(5)) = 0x22220a00; > > + > > +??? /* Setup UART1 and SPI2 pins */ > > +??? mx31_uart1_hw_init(); > > +??? mx31_spi2_hw_init(); > > + > > +??? gd->bd->bi_arch_number = > MACH_TYPE_MX31_3DS; /* board id for linux */ > > Hm... that's the MACH ID for the Freescale MX31_3DS board. > You are > talking about PDK instead. Are these two really the same? Yes, they are the same. In Linux we also refer to mx31pdk board and its machine type is MX31_3DS. > > > +??? gd->bd->bi_boot_params = > PHYS_SDRAM_1 + 0x100; > > + > > +??? return 0; > > +} > > + > > +int checkboard(void) > > +{ > > +??? printf("Board: i.MX31 MAX PDK > (3DS)\n"); > > It seems they are the same? > > > +/* Disabled due to compilation errors in cmd_bootm.c > (IMLS seems to require > > + * that CFG_NO_FLASH is undefined). > > + */ > > Incorrect multiline comment style. > > > +#define CONFIG_ENV_IS_NOWHERE??? 1 > > Why don't you put the environment in NAND? With the current patchset only booting from NAND is supported. The NAND driver has not been added yet. Regards, Fabio Estevam