From: Hans Verkuil Subject: Re: [PATCH v3 03/14] v4l: ti-vpe: Use video_device_release_empty Date: Tue, 11 Mar 2014 13:02:54 +0100 Message-ID: <531EFB6E.9060700@xs4all.nl> References: <1393922965-15967-1-git-send-email-archit@ti.com> <1394526833-24805-1-git-send-email-archit@ti.com> <1394526833-24805-4-git-send-email-archit@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1394526833-24805-4-git-send-email-archit@ti.com> Sender: linux-media-owner@vger.kernel.org To: Archit Taneja Cc: k.debski@samsung.com, linux-media@vger.kernel.org, linux-omap@vger.kernel.org List-Id: linux-omap@vger.kernel.org On 03/11/14 09:33, Archit Taneja wrote: > The video_device struct is currently embedded in the driver data struct vpe_dev. > A vpe_dev instance is allocated by the driver, and the memory for the vfd is a > part of this struct. > > The v4l2 core, however, manages the removal of the vfd region, through the > video_device's .release() op, which currently is the helper > video_device_release. This causes memory corruption, and leads to issues when > we try to re-insert the vpe module. > > Use the video_device_release_empty helper function instead > > Signed-off-by: Archit Taneja Reviewed-by: Hans Verkuil > --- > drivers/media/platform/ti-vpe/vpe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c > index f1eae67..0363df6 100644 > --- a/drivers/media/platform/ti-vpe/vpe.c > +++ b/drivers/media/platform/ti-vpe/vpe.c > @@ -2000,7 +2000,7 @@ static struct video_device vpe_videodev = { > .fops = &vpe_fops, > .ioctl_ops = &vpe_ioctl_ops, > .minor = -1, > - .release = video_device_release, > + .release = video_device_release_empty, > .vfl_dir = VFL_DIR_M2M, > }; > >