Return-path: Received: from smtp-vbr4.xs4all.nl ([194.109.24.24]:4093 "EHLO smtp-vbr4.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753828AbaCKMYu (ORCPT ); Tue, 11 Mar 2014 08:24:50 -0400 Message-ID: <531F0060.3030005@xs4all.nl> Date: Tue, 11 Mar 2014 13:24:00 +0100 From: Hans Verkuil MIME-Version: 1.0 To: Archit Taneja CC: k.debski@samsung.com, linux-media@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v3 11/14] v4l: ti-vpe: Fix initial configuration queue data References: <1393922965-15967-1-git-send-email-archit@ti.com> <1394526833-24805-1-git-send-email-archit@ti.com> <1394526833-24805-12-git-send-email-archit@ti.com> In-Reply-To: <1394526833-24805-12-git-send-email-archit@ti.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 03/11/14 09:33, Archit Taneja wrote: > The vpe output and capture queues are initially configured to default values in > vpe_open(). A G_FMT before any S_FMTs will result in these values being > populated. > > The colorspace and bytesperline parameter of this initial configuration are > incorrect. This breaks compliance when as we get 'TRY_FMT(G_FMT) != G_FMT'. > > Fix the initial queue configuration such that it wouldn't need to be fixed by > try_fmt. > > Signed-off-by: Archit Taneja Reviewed-by: Hans Verkuil > --- > drivers/media/platform/ti-vpe/vpe.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti-vpe/vpe.c > index 5591d04..85d1122 100644 > --- a/drivers/media/platform/ti-vpe/vpe.c > +++ b/drivers/media/platform/ti-vpe/vpe.c > @@ -2012,9 +2012,11 @@ static int vpe_open(struct file *file) > s_q_data->fmt = &vpe_formats[2]; > s_q_data->width = 1920; > s_q_data->height = 1080; > - s_q_data->sizeimage[VPE_LUMA] = (s_q_data->width * s_q_data->height * > + s_q_data->bytesperline[VPE_LUMA] = (s_q_data->width * > s_q_data->fmt->vpdma_fmt[VPE_LUMA]->depth) >> 3; > - s_q_data->colorspace = V4L2_COLORSPACE_SMPTE170M; > + s_q_data->sizeimage[VPE_LUMA] = (s_q_data->bytesperline[VPE_LUMA] * > + s_q_data->height); > + s_q_data->colorspace = V4L2_COLORSPACE_REC709; > s_q_data->field = V4L2_FIELD_NONE; > s_q_data->c_rect.left = 0; > s_q_data->c_rect.top = 0; >