From: t.figa@samsung.com (Tomasz Figa) Date: Wed, 09 Apr 2014 11:04:41 +0200 Subject: [PATCH v7 1/3] ARM: EXYNOS: initial board support for exynos5260 SoC In-Reply-To: References: <1396519224-18712-1-git-send-email-rahul.sharma@samsung.com> <1396519224-18712-2-git-send-email-rahul.sharma@samsung.com> Message-ID: <53450D29.7020207@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07.04.2014 10:38, Sachin Kamat wrote: > Hi Rahul, > > On 3 April 2014 15:30, Rahul Sharma wrote: >> From: Pankaj Dubey >> >> This patch add basic arch side support for exynos5260 SoC. > > >> @@ -374,6 +374,7 @@ static char const *exynos_dt_compat[] __initconst = { >> "samsung,exynos4412", >> "samsung,exynos5", >> "samsung,exynos5250", >> + "samsung,exynos5260", > > I don't think we should be adding this as we do not yet have any soc > specific quirk. > Compatibility to generic string, "samsung,exynos5" should be sufficient. > Yes. Unless a SoC specific quirk that needs to be handled at such low level stage emerges, there is no need to add such compatible string to the kernel. Best regards, Tomasz