From: "Jan Beulich" Subject: Re: [PATCH v5 11/14] autoconf: xen: move standard variables to a generic place Date: Wed, 21 May 2014 14:54:38 +0100 Message-ID: <537CCC3E02000078000148A4@mail.emea.novell.com> References: <1400589095-3872-1-git-send-email-mcgrof@do-not-panic.com> <1400589095-3872-12-git-send-email-mcgrof@do-not-panic.com> <537B76D1020000780001422C@suse.com> <20140520175445.GR13289@wotan.suse.de> <537C72B702000078000145A6@mail.emea.novell.com> <537C7BDF020000780001461C@mail.emea.novell.com> <1400668395.4856.12.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Wn6yf-0007Xz-GX for xen-devel@lists.xenproject.org; Wed, 21 May 2014 13:54:41 +0000 In-Reply-To: <1400668395.4856.12.camel@kazak.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Keir Fraser , Tim Deegan , Luis Rodriguez , Ian Jackson , xen-devel@lists.xenproject.org, Samuel Thibault List-Id: xen-devel@lists.xenproject.org >>> On 21.05.14 at 12:33, wrote: > On Wed, 2014-05-21 at 09:11 +0100, Jan Beulich wrote: >> >>> On 21.05.14 at 10:03, wrote: >> > On Wed, May 21, 2014 at 12:32 AM, Jan Beulich wrote: >> >>>>> On 20.05.14 at 19:54, wrote: >> >>> On Tue, May 20, 2014 at 07:37:53AM -0600, Jan Beulich wrote: >> >>>> >>> On 20.05.14 at 14:31, wrote: >> >>>> > --- a/config/StdGNU.mk >> >>>> > +++ b/config/StdGNU.mk >> >>>> > @@ -1,3 +1,17 @@ >> >>>> > +# These are standard defaults which you can use to avoid having >> >>>> > +# to run ./configure -- you can use this to compile the hypervisor >> >>>> > +# and the mini os: >> >>>> > +# >> >>>> > +# make xen >> >>>> > +# sudo make -C xen install >> >>>> > +# >> >>>> > +# make -C extras/mini-os >> >>>> > +include $(XEN_ROOT)/config/defaults.mk >> >>>> > + >> >>>> > +# This comes from running configure and will override >> >>>> > +# the defaults. >> >>>> > +-include $(XEN_ROOT)/config/Toplevel.mk >> >>>> >> >>>> So what is the result of running one of the above make invocations >> >>>> without having run ./configure, then running ./configure before >> >>>> running the same make invocation (for an incremental update) >> >>>> again? >> >>> >> >>> In my last v4 you pointed out two targets which you wished to >> >>> ensure would not require running configure, both of those targets: >> >>> >> >>> make xen -j $(getconf _NPROCESSORS_ONLN) >> >>> make -C extras/mini-os -j $(getconf _NPROCESSORS_ONLN) >> >>> >> >>> I have ensured this in this series and the above change indeed >> >>> is what you were looking for. >> >> >> >> I understand that; what I was asking however was what the effect >> >> of the named sequence of operations would be, i.e. whether that >> >> then perhaps would unexpectedly change things between the >> >> original and the incremental make runs. Obviously an incremental >> >> make should change _only_ things where the contributing sources >> >> changed, but nothing resulting merely from the intermediate >> >> ./configure run. >> > >> > Nothing I've introduced here should hamper the typical compile as what >> > you described you want. Let me know if you find issues though. We're >> > human. >> >> Did you try it? I would expect the PREFIX change (from /usr to >> /usr/local) alone would already alter things. > > Do either the xen or extras/mini-os subtrees depend on PREFIX at all? > > At most I would expoect xen to depend on BOOT_DIR which I don't think is > overridable with configure? I would have expected the /usr use in x86_64.mk to have got converted to $(PREFIX), but looks like it's still hard coded. With that there indeed shouldn't be any use of PREFIX in those sub-trees. Jan