Received: from eggs.gnu.org ([2001:4830:134:3::10]:50160)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1Wnwdn-00011g-OQ
	for qemu-devel@nongnu.org; Fri, 23 May 2014 17:04:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1Wnwdi-0000gt-9R
	for qemu-devel@nongnu.org; Fri, 23 May 2014 17:04:35 -0400
Message-ID: <537FB7DD.6080302@msgid.tls.msk.ru>
Date: Sat, 24 May 2014 01:04:29 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <y> <cover.1399641611.git.tamlokveer@gmail.com>
	<859e114fe7fcfbd22eddfb8cde3846662598c564.1399641611.git.tamlokveer@gmail.com>
In-Reply-To: <859e114fe7fcfbd22eddfb8cde3846662598c564.1399641611.git.tamlokveer@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/4] audio: replace
 fprintf(stderr, ...) with error_report() in audio
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Le Tan <tamlokveer@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, jan.kiszka@web.de, afaerber@suse.de

10.05.2014 03:55, Le Tan wrote:
> Replace fprintf(stderr,...) with error_report() in files audio/*.
> The trailing "\n"s of the @fmt argument have been removed
> because @fmt of error_report() should not contain newline.

Please always check your patches using ./scripts/checkpatch.pl.

I've applied this your patch to -trivial, after fixing this
place:

> --- a/audio/wavcapture.c
> +++ b/audio/wavcapture.c
> @@ -63,8 +63,8 @@ static void wav_destroy (void *opaque)
>          }
>      doclose:
>          if (fclose (wav->f)) {
> -            fprintf (stderr, "wav_destroy: fclose failed: %s",
> -                     strerror (errno));
> +            error_report("wav_destroy: fclose failed: %s",
> +                         strerror (errno));

to not contain an extra space after strerror, and folding whole
thing into one line.  Yes, the code around has the same style,
but the usual rule is that you fix style issues in the code
you touch, to comply with the coding style used in qemu.

Thanks,

/mjt