Received: from eggs.gnu.org ([2001:4830:134:3::10]:36547)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1X4sOl-0002tK-PX
	for qemu-devel@nongnu.org; Wed, 09 Jul 2014 09:59:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1X4sOf-00056g-Kn
	for qemu-devel@nongnu.org; Wed, 09 Jul 2014 09:59:03 -0400
Message-ID: <53BD4A94.2000300@msgid.tls.msk.ru>
Date: Wed, 09 Jul 2014 15:58:44 +0200
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <53B57D5B.2070204@gmail.com>
In-Reply-To: <53B57D5B.2070204@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH trivial] qemu-img: Remove
 redundancy "ret = -1"
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Chen Gang <gang.chen.5i5j@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-trivial@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com

03.07.2014 17:57, Chen Gang wrote:
> In this case, 'ret' is already '-1', so need not do it again.

It's a very minor thing in an error path, maybe compiler even
eliminates this statement entirely by its own already.

Not sure it is worth the effort but applied to the -trivial tree
anyway, thanks!

/mjt