From: mkl@pengutronix.de (Marc Kleine-Budde) Date: Mon, 14 Jul 2014 16:09:04 +0200 Subject: [PATCH v2 4/4] can: flexcan: add vf610 support for FlexCAN In-Reply-To: <5b42e19c9741a0b54420ade131f84408@agner.ch> References: <3b047f9eb64ef01a958d83706af8f7e973358420.1405322992.git.stefan@agner.ch> <53C38FD9.8070403@pengutronix.de> <5b42e19c9741a0b54420ade131f84408@agner.ch> Message-ID: <53C3E480.9050509@pengutronix.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 07/14/2014 03:37 PM, Stefan Agner wrote: > Am 2014-07-14 10:07, schrieb Marc Kleine-Budde: > >>> + /* >>> + * On Vybrid, disable memory error detection interrupts >>> + * and freeze mode. >>> + * This also works around errata e5295 which generates >>> + * false positive memory errors and put the device in >>> + * freeze mode. >>> + */ >>> + if (priv->devtype_data->features & FLEXCAN_HAS_MECR_FEATURES) { >>> + /* >>> + * Follow the protocol as described in "Detection >>> + * and Correction of Memory Errors" to write to >>> + * MECR register >>> + */ >> >> >> One nitpick regarding the comment. In driver/net, the preferred >> multi-line comment style is >> > > Just a few lines above that one, another multi-line comment is written > with the empty line at start... With this changed to the net comment > style, we would end up in a mixed style... What do you think? Okay, keep the commenting style of the driver. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de | -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 242 bytes Desc: OpenPGP digital signature URL: