From: David Vrabel Subject: Re: [PATCH v2 1/2] xen: Silence compiler warnings Date: Mon, 28 Jul 2014 14:11:58 +0100 Message-ID: <53D64C1E.8020508@citrix.com> References: <1405199388-5692-1-git-send-email-daniel.kiper@oracle.com> <1405199388-5692-2-git-send-email-daniel.kiper@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XBkij-0002Hl-Kg for xen-devel@lists.xenproject.org; Mon, 28 Jul 2014 13:12:05 +0000 In-Reply-To: <1405199388-5692-2-git-send-email-daniel.kiper@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Daniel Kiper , linux-kernel@vger.kernel.org, x86@kernel.org, xen-devel@lists.xenproject.org Cc: jeremy@goop.org, matt.fleming@intel.com, ian.campbell@citrix.com, andrew.cooper3@citrix.com, stefano.stabellini@eu.citrix.com, mingo@redhat.com, jbeulich@suse.com, hpa@zytor.com, boris.ostrovsky@oracle.com, tglx@linutronix.de List-Id: xen-devel@lists.xenproject.org On 12/07/14 22:09, Daniel Kiper wrote: > Add inline keyword to silence the following compiler > warnings if xen_efi_probe() is not used: The title and should be: xen: make stub xen_efi_probe() static inline Empty stub functions in headers should be inline or the compiler will warn that it is unused. Do you want this to go via the Xen tree or the EFI one? David