From: "H. Peter Anvin" Subject: Re: [PATCH RFC v4 net-next 01/26] net: filter: add "load 64-bit immediate" eBPF instruction Date: Wed, 13 Aug 2014 14:27:36 -0700 Message-ID: <53EBD848.1060203@zytor.com> References: <1407916658-8731-1-git-send-email-ast@plumgrid.com> <1407916658-8731-2-git-send-email-ast@plumgrid.com> <53EBD6D5.3050706@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andy Lutomirski Cc: Alexei Starovoitov , "David S. Miller" , Ingo Molnar , Linus Torvalds , Steven Rostedt , Daniel Borkmann , Chema Gonzalez , Eric Dumazet , Peter Zijlstra , Andrew Morton , Kees Cook , Linux API , Network Development , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-api@vger.kernel.org On 08/13/2014 02:23 PM, Andy Lutomirski wrote: > On Wed, Aug 13, 2014 at 2:21 PM, H. Peter Anvin wrote: >> One thing about this that may be a serious concern: allowing the user to >> control 8 contiguous bytes of kernel memory may be a security hazard. > > I'm confused. What kind of memory? I can control a lot more than 8 > bytes of stack very easily. > > Or are you concerned about 8 contiguous bytes of *executable* memory? > Yes. Useful for some kinds of ROP custom gadgets. -hpa