From: "Jan Beulich" Subject: Re: [v5][PATCH 03/10] xen:x86: define a new hypercall to get RMRR mappings Date: Thu, 28 Aug 2014 07:50:23 +0100 Message-ID: <53FEED4F020000780002E76C@mail.emea.novell.com> References: <1409050980-21933-1-git-send-email-tiejun.chen@intel.com> <1409050980-21933-4-git-send-email-tiejun.chen@intel.com> <53FC774D.8000501@citrix.com> <53FC9BB1020000780002D986@mail.emea.novell.com> <53FD3669.3070705@intel.com> <53FD9C03020000780002DEFF@mail.emea.novell.com> <53FD86E9.4020205@intel.com> <53FE92C6.6050605@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53FE92C6.6050605@intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tiejun Chen Cc: kevin.tian@intel.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, Andrew Cooper , ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org >>> On 28.08.14 at 04:24, wrote: > If you guys have no more comments, could I send a new series to review? You certainly can do so at any time, but as said before I didn't get to looking at the current version yet; briefly having looked at the first two patches I'm already pretty convinced that the structuring still isn't right (you shouldn't be exposing VT-d internals into arbitrary parts of the hypervisor, but rather introduce a new vendor IOMMU hook/actor to get at the reserved page information - this all still goes along the lines of you apparently not understanding that a reasonable level of abstraction helps in the long term maintenance of such code). Jan