From: Marek Vasut Date: Wed, 5 Aug 2020 13:35:41 +0200 Subject: [PATCH v1] Makefile: socfpga: Generate spl/u-boot-splx4.sfp with 4 SPL images In-Reply-To: References: <20200805081537.182543-1-chee.hong.ang@intel.com> Message-ID: <53cd5261-920e-1fa0-615a-3fe15ce490a4@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 8/5/20 11:26 AM, Tan, Ley Foon wrote: Hi, [...] >>>>> diff --git a/Makefile b/Makefile >>>>> index 2629a74..13429a0 100644 >>>>> --- a/Makefile >>>>> +++ b/Makefile >>>>> @@ -1578,8 +1578,9 @@ u-boot.spr: spl/u-boot-spl.img u-boot.img >>>> FORCE >>>>> ifneq ($(CONFIG_ARCH_SOCFPGA),) quiet_cmd_socboot = SOCBOOT >> $@ >>>>> cmd_socboot = cat spl/u-boot-spl.sfp spl/u-boot-spl.sfp \ >>>>> - spl/u-boot-spl.sfp spl/u-boot-spl.sfp \ >>>>> - u-boot.img > $@ || rm -f $@ >>>>> + spl/u-boot-spl.sfp \ >>>>> + spl/u-boot-spl.sfp > spl/u-boot-splx4.sfp ; \ >>>>> + cat spl/u-boot-splx4.sfp u-boot.img > $@ || rm -f $@ >>>> >>>> Isn't that what the existing code does already ? >>>> >>>> Also, this will I think fail on 128k erase block size NAND due to >>>> missing padding. >>> This is to generate an output file (spl/u-boot-splx4.sfp) with 4 SPL images, >> each SPL image size is 256KB. >>> So, spl/u-boot-splx4.sfp is always with 1MB size (4x256KB). Shouldn't have >> problem for 128KB erase size NAND. >> >> Isn't the SPL padded to 64 kiB each ? > Cyclone 5 and Arria 10 have different size. > > Cyclone 5 SPL: 64KB each, spl/u-boot-splx4.sfp is 256KB > > Arria 10 SPL: 256KB each, spl/u-boot-splx4.sfp is 1MB So are you sure this will work on NAND with 128 kiB erase blocks on CV/AV ? I think you will run into problems with padding there. But maybe we don't support that anyway, so add a comment and be done with it.