Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D66B7CD6E4A for ; Thu, 4 Jun 2026 06:21:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 479591126AF; Thu, 4 Jun 2026 06:21:41 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="MC+bUWhU"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id BFB1A1126BF; Thu, 4 Jun 2026 06:21:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780554100; x=1812090100; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version:content-transfer-encoding; bh=nq2WSK5xmKwm4MzcZ6nt55HrNcSdZYR6vDSVMN8NgtI=; b=MC+bUWhUYS0zsk8hEJhcnCkHKanUlplAezuW35CrhmT9jQwSCgfZ6cnI oMCSdHCgA2hfnF9cmRR5GH0pP5RIluPwb/wYNz7ljRAfZf+1OYC+pfeo+ fkCAPLQpn2GmdP39btsJ8y+zE6sc+e7siGQuv6tDyUXb48/Wzp6Jfucp+ zpXJ+8JHN5WYdc+fwrdX4cN5a+PXopeiV+puNo5Sq8+Z1rrBy+SMj/XNl RD2xH/3xJkmIG3aCZ3LT1jHXTMbZ+QiAAe9cxNUFau6rcoO0k4d8koBtP 9SjlGzYKLCfB5vYdwjtPYIY5AQpMehxL+o5vSX71tHOjXfqXolHtqNqO4 Q==; X-CSE-ConnectionGUID: I/AqkPERThOwvCns3+PQeQ== X-CSE-MsgGUID: PfOzr4UFQjOCcEtPuwXzmA== X-IronPort-AV: E=McAfee;i="6800,10657,11806"; a="85227550" X-IronPort-AV: E=Sophos;i="6.24,186,1774335600"; d="scan'208";a="85227550" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2026 23:21:39 -0700 X-CSE-ConnectionGUID: syg+rOFuS4WBEebfqI3wUA== X-CSE-MsgGUID: qXCUPZdnRfWn3mwIYtlaGg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,186,1774335600"; d="scan'208";a="248797920" Received: from vpanait-mobl.ger.corp.intel.com (HELO localhost) ([10.245.245.33]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2026 23:21:37 -0700 From: Jani Nikula To: =?utf-8?Q?Micha=C5=82?= Grzelak , intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: Suraj Kandpal , =?utf-8?Q?Micha=C5=82?= Grzelak Subject: Re: [PATCH v6 3/8] drm/i915/bios: print VS/PE-O port info In-Reply-To: <20260603230544.1993439-4-michal.grzelak@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260603230544.1993439-1-michal.grzelak@intel.com> <20260603230544.1993439-4-michal.grzelak@intel.com> Date: Thu, 04 Jun 2026 09:21:34 +0300 Message-ID: <53cd94251c2a9272b3de53c5e14d2f608899b9e7@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 04 Jun 2026, Micha=C5=82 Grzelak wrote: > Issue a debug message when port asks to override default Vswing / > Preemphasis tables. > > Add helper intel_bios_encoder_requests_vspeo() to check if port > requests for overriding default VS/PE tables. > > v3->v4 > - change debug message when requesting VS/PE-O (Suraj) > > Signed-off-by: Micha=C5=82 Grzelak > Reviewed-by: Suraj Kandpal > --- > drivers/gpu/drm/i915/display/intel_bios.c | 10 ++++++++++ > drivers/gpu/drm/i915/display/intel_bios.h | 1 + > 2 files changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/= i915/display/intel_bios.c > index d071f0e5d4380..204176088a7cd 100644 > --- a/drivers/gpu/drm/i915/display/intel_bios.c > +++ b/drivers/gpu/drm/i915/display/intel_bios.c > @@ -2781,6 +2781,11 @@ static void print_ddi_port(const struct intel_bios= _encoder_data *devdata) > "Port %c supports dynamic DDI allocation in TCSS\n", > port_name(port)); >=20=20 > + if (intel_bios_encoder_requests_vspeo(devdata)) > + drm_dbg_kms(display->drm, > + "Port %c requests VS/PE-O\n", I don't think it's helpful to use these acronyms in debug logging. "vswing/pre-emphasis override" > + port_name(port)); > + > hdmi_level_shift =3D intel_bios_hdmi_level_shift(devdata); > if (hdmi_level_shift >=3D 0) { > drm_dbg_kms(display->drm, > @@ -3809,6 +3814,11 @@ int intel_bios_hdmi_ddc_pin(const struct intel_bio= s_encoder_data *devdata) > return map_ddc_pin(devdata->display, devdata->child.ddc_pin); > } >=20=20 > +bool intel_bios_encoder_requests_vspeo(const struct intel_bios_encoder_d= ata *devdata) > +{ > + return devdata->display->vbt.version >=3D 218 && devdata->child.use_vbt= _vswing; > +} > + > bool intel_bios_encoder_supports_typec_usb(const struct intel_bios_encod= er_data *devdata) > { > return devdata->display->vbt.version >=3D 195 && devdata->child.dp_usb_= type_c; > diff --git a/drivers/gpu/drm/i915/display/intel_bios.h b/drivers/gpu/drm/= i915/display/intel_bios.h > index 75dff27b42289..7a50a272cd27d 100644 > --- a/drivers/gpu/drm/i915/display/intel_bios.h > +++ b/drivers/gpu/drm/i915/display/intel_bios.h > @@ -73,6 +73,7 @@ bool intel_bios_get_dsc_params(struct intel_encoder *en= coder, > const struct intel_bios_encoder_data * > intel_bios_encoder_data_lookup(struct intel_display *display, enum port = port); >=20=20 > +bool intel_bios_encoder_requests_vspeo(const struct intel_bios_encoder_d= ata *devdata); > bool intel_bios_encoder_supports_dvi(const struct intel_bios_encoder_dat= a *devdata); > bool intel_bios_encoder_supports_hdmi(const struct intel_bios_encoder_da= ta *devdata); > bool intel_bios_encoder_supports_dp(const struct intel_bios_encoder_data= *devdata); --=20 Jani Nikula, Intel