From: "Jan Beulich" Subject: Re: [v5][PATCH 03/10] xen:x86: define a new hypercall to get RMRR mappings Date: Tue, 02 Sep 2014 14:15:12 +0100 Message-ID: <5405DF00020000780002FD52@mail.emea.novell.com> References: <1409050980-21933-1-git-send-email-tiejun.chen@intel.com> <1409050980-21933-4-git-send-email-tiejun.chen@intel.com> <53FC774D.8000501@citrix.com> <53FC9BB1020000780002D986@mail.emea.novell.com> <53FD3669.3070705@intel.com> <53FD9C03020000780002DEFF@mail.emea.novell.com> <53FD86E9.4020205@intel.com> <53FE92C6.6050605@intel.com> <53FEED4F020000780002E76C@mail.emea.novell.com> <53FED5AF.7080803@intel.com> <53FED802.7080707@intel.com> <53FEF9F8020000780002E7E2@mail.emea.novell.com> <53FFED5D.7040406@intel.com> <54006196020000780002EFC6@mail.emea.novell.com> <54043FEA.6080100@intel.com> <540466A8020000780002F656@mail.emea.novell.com> <540594F2.4000406@intel.com> <5405B4E1020000780002FCBC@mail.emea.novell.com> <5405A597.9040103@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5405A597.9040103@intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tiejun Chen Cc: kevin.tian@intel.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, Andrew Cooper , ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org >>> On 02.09.14 at 13:10, wrote: > On 2014/9/2 18:15, Jan Beulich wrote: >>>>> On 02.09.14 at 11:59, wrote: >>> + case XENMEM_reserved_device_memory_map: >>> + { >>> + struct xen_mem_reserved_device_memory *xmrdm = NULL; >>> + struct xen_mem_reserved_device_memory_map xmrdmm; >>> + XEN_GUEST_HANDLE(xen_mem_reserved_device_memory_t) buffer; >>> + XEN_GUEST_HANDLE_PARAM(xen_mem_reserved_device_memory_t) buffer_param; >>> + const struct iommu_ops *ops = iommu_get_ops(); >>> + unsigned int nr_entries = 0; >>> + unsigned int i = 0; >>> + >>> + xmrdm = ops->get_device_reserved_memory(&nr_entries); > > Do we still need this iommu_ops somewhere else? Not this one, but another one (as I had described further down). >>> + if ( !nr_entries ) > > Do we still need this 'nr_entries' here? Doesn't look like so. But it's you coding this up - you ought to clearly see what is needed and what not. Jan