From: "cron2 (Code Review)" Date: Mon, 14 Jul 2025 09:14:44 +0000 In-Reply-To: References: Reply-To: gert@...1296..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net, frank@...2641... Message-ID: <5407b7eb72c475c83cd492630a6e00f948fa5fbc-EmailReviewComments-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="RZOqSwF6lW0="; charset=UTF-8 Subject: [Openvpn-devel] [M] Change in openvpn[master]: reliable: Review and fix gc_arena usage List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: flichtenheld Cc: plaisthos , openvpn-devel --RZOqSwF6lW0= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: flichtenheld, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/ope= nvpn/+/1083?usp=3Demail ) Change subject: reliable: Review and fix gc_arena usage ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: This looks generally good to me - move `int i` declarations inside `for (in= t i;...)` loops, move `gc_arena` declarations into the error case, thus avo= iding malloc/free calls in the fast path. The OpenBSD test fails were due to local problems (stuck openvpn process, s= o t_client failed the "must not ping before OpenVPN is up" check). I would prefer a second pair of eyes on this, though... thus only +1 -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1083?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I8cefa9a406fe90bb3cbe481304782c639691a3a0 Gerrit-Change-Number: 1083 Gerrit-PatchSet: 3 Gerrit-Owner: flichtenheld Gerrit-Reviewer: cron2 Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-Attention: flichtenheld Gerrit-Comment-Date: Mon, 14 Jul 2025 09:14:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment --RZOqSwF6lW0= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: flichtenheld, plaisthos.

Patch set 3:Code-Review +1=

V= iew Change

1 comment:

  • Patchset:

    • Patch Set #3:

      This looks generally good to me - move `int = i` declarations inside `for (int i;...)` loops, move `gc_arena` declaration= s into the error case, thus avoiding malloc/free calls in the fast path.

      The OpenBSD tes= t fails were due to local problems (stuck openvpn process, so t_client fail= ed the "must not ping before OpenVPN is up" check).

      I would prefer a second = pair of eyes on this, though... thus only +1

To v= iew, visit change 1083. To unsubscribe, or for help writing mail filters, visit= settings.

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I8cefa9a406fe90bb3cbe4813047= 82c639691a3a0
Gerrit-Change-Number: 1083
Gerrit-PatchSet: 3
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: cron2 <gert@...1296...>=
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-Attention: flichtenheld <frank@...2375...= 41...>
Gerrit-Comment-Date: Mon, 14 Jul 2025 09:14:44= +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
--RZOqSwF6lW0=--