From: Juergen Gross Subject: Re: [Xen-devel] [PATCH 2/3] xen: eliminate scalability issues from initrd handling Date: Fri, 05 Sep 2014 10:04:26 +0200 Message-ID: <54096E8A.6010904@suse.com> References: <1409834326-29287-1-git-send-email-jgross@suse.com> <1409834326-29287-3-git-send-email-jgross@suse.com> <5408607F.6020108@citrix.com> <540893570200007800030E4C@mail.emea.novell.com> <54087CE3.6020400@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54087CE3.6020400@citrix.com> Sender: linux-kernel-owner@vger.kernel.org To: David Vrabel , Jan Beulich Cc: boris.ostrovsky@oracle.com, xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org On 09/04/2014 04:53 PM, David Vrabel wrote: > On 04/09/14 15:29, Jan Beulich wrote: >>>>> On 04.09.14 at 14:52, wrote: >>> On 04/09/14 13:38, Juergen Gross wrote: >>>> --- a/arch/x86/xen/xen-head.S >>>> +++ b/arch/x86/xen/xen-head.S >>>> @@ -124,6 +124,9 @@ NEXT_HYPERCALL(arch_6) >>>> ELFNOTE(Xen, XEN_ELFNOTE_L1_MFN_VALID, >>>> .quad _PAGE_PRESENT; .quad _PAGE_PRESENT) >>>> ELFNOTE(Xen, XEN_ELFNOTE_SUSPEND_CANCEL, .long 1) >>>> +#ifdef CONFIG_X86_64 >>>> + ELFNOTE(Xen, XEN_ELFNOTE_MOD_START_PFN, .long 1) >>>> +#endif >>> >>> Why X86_64 only? If there's a good reason the commit message needs to >>> explain why. >> >> Does native 32-bit support huge initrd? > > Does that matter? If the MOD_START_PFN options works with a 32-bit guest > then it should use it, regardless of whether it is essential or not. > Because this reduces the #ifdef'ery. Okay, I'll verify it's working on 32-bit, too. Juergen