Received: from eggs.gnu.org ([2001:4830:134:3::10]:58692) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XR4cU-0002Lk-Le for qemu-devel@nongnu.org; Mon, 08 Sep 2014 15:29:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XR4cP-00088L-O1 for qemu-devel@nongnu.org; Mon, 08 Sep 2014 15:28:58 -0400 Message-ID: <540E0372.9060901@redhat.com> Date: Mon, 08 Sep 2014 13:28:50 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140908140826.3a673423@redhat.com> In-Reply-To: <20140908140826.3a673423@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KqGTM3IUKuV9q7MolqCrQP9BQkE7brbTw" Subject: Re: [Qemu-devel] [PATCH] exec: file_ram_alloc(): print error when prealloc fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino , qemu-devel Cc: peter.maydell@linaro.org, mtosatti@redhat.com, qemu-stable@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KqGTM3IUKuV9q7MolqCrQP9BQkE7brbTw Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 09/08/2014 12:08 PM, Luiz Capitulino wrote: > If memory allocation fails when using the -mem-prealloc command-line > option, QEMU exits without printing any error information to > the user: >=20 > # qemu [...] -m 1G -mem-prealloc -mem-path /dev/hugepages > # echo $? > 1 >=20 > This commit adds an error message, so that we print instead: >=20 > # qemu [...] -m 1G -mem-prealloc -mem-path /dev/hugepages > qemu: unable to map backing store for hugepages: Cannot allocate memor= y >=20 > Signed-off-by: Luiz Capitulino > --- > exec.c | 1 + > 1 file changed, 1 insertion(+) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --KqGTM3IUKuV9q7MolqCrQP9BQkE7brbTw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUDgNyAAoJEKeha0olJ0NqAXoH/RejmYTAUBxPyK5xK6fSG9qf MdrSO3LYaOM9xB6te0NzaXI8D5b0HdmeZu27I05ZfxJ7S+FvvTDXTCGX1O6eDgEe fn3YutvhkPwGkPyisIJroEfk9/Ll3xdoqHPq3FszHwXxJ1r1f/1/zbhkjXuIm/FY gHHENuUOUeSQrB11kwpeBJTPh6G/N6s8aoqQmZGpqO/Dz27SoJEY6ji4ayuLM+jn wXqk2KR5zydLMAdyVn/t1JvgaQLmn8j/TyH+JyinsNAB75Q4lDLCxlsUggN8/48v iz6Tl1gc1abw/aRLk+2s4jWLluWUiZOHjp6SaplAN6uKiE+KuHa0DnBphrJQrk8= =JZ+N -----END PGP SIGNATURE----- --KqGTM3IUKuV9q7MolqCrQP9BQkE7brbTw--