From: "Jan Beulich" Subject: Re: [v6][PATCH 2/7] tools/libxc: introduce hypercall for xc_reserved_device_memory_map Date: Thu, 11 Sep 2014 16:21:44 +0100 Message-ID: <5411DA280200007800034036@mail.emea.novell.com> References: <1410328190-6372-1-git-send-email-tiejun.chen@intel.com> <1410328190-6372-3-git-send-email-tiejun.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1410328190-6372-3-git-send-email-tiejun.chen@intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tiejun Chen Cc: kevin.tian@intel.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, yang.z.zhang@intel.com List-Id: xen-devel@lists.xenproject.org >>> On 10.09.14 at 07:49, wrote: > + if ( errno == ENOBUFS ) > + *max_entries = memmap.nr_entries; > + > + return rc ? -errno : memmap.nr_entries; > +} Isn't libxc generally aiming at using POSIX style return values, i.e. -1 one error with errno indicating the details? Furthermore you're even inconsistent with yourself, as you return -1 in an earlier error path. Jan