Message-ID: <54212cc9-297e-737c-1ae0-0aa5af9d3bfd@...2181...> Date: Wed, 16 Nov 2022 13:35:40 +0100 MIME-Version: 1.0 Content-Language: en-US References: <20221115122940.1947284-1-arne@...1227...> <7e99c14a-0d3d-b539-f173-a00d79e52811@...2181...> From: Antonio Quartulli In-Reply-To: Subject: Re: [Openvpn-devel] [PATCH] Fix logic error in checking early negotiation support check List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit To: Arne Schwabe , openvpn-devel@lists.sourceforge.net Hi, On 16/11/2022 01:54, Arne Schwabe wrote: > Without the == it is enough if any of the bits EARLY_NEG_START is set > (0xf00000), we want them all to be set. If EARLY_NEG_START were a > flag/single bit, you would be right. Ouch, I indeed assumed it was 1 bit only.. Cheers, -- Antonio Quartulli