From: Dhinakaran Pandiyan Subject: Re: [PATCH v2 4/6] drm/i915: Disable PSR when a PSR aux error happen Date: Fri, 19 Oct 2018 16:14:22 -0700 Message-ID: <542f1e8eef7fd853ea9ef52b7b1ade3abeaf7141.camel@intel.com> References: <20181011004124.4110-1-jose.souza@intel.com> <20181011004124.4110-4-jose.souza@intel.com> Reply-To: dhinakaran.pandiyan@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id C23006E07A for ; Fri, 19 Oct 2018 23:14:40 +0000 (UTC) In-Reply-To: <20181011004124.4110-4-jose.souza@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?ISO-8859-1?Q?Jos=E9?= Roberto de Souza , intel-gfx@lists.freedesktop.org, Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= , Maarten Lankhorst List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE4LTEwLTEwIGF0IDE3OjQxIC0wNzAwLCBKb3PDqSBSb2JlcnRvIGRlIFNvdXph IHdyb3RlOgo+IFdoaWxlIFBTUiBpcyBhY3RpdmUgaGFyZHdhcmUgd2lsbCBkbyBhdXggdHJhbnNh Y3Rpb25zIGJ5IGl0IHNlbGYgdG8KPiB3YWtldXAgc2luayB0byByZWNlaXZlIGEgbmV3IGZyYW1l IHdoZW4gbmVjZXNzYXJ5LiBJZiB0aGF0Cj4gdHJhbnNhY3Rpb24gaXMgbm90IGFja2VkIGJ5IHNp bmssIGhhcmR3YXJlIHdpbGwgdHJpZ2dlciB0aGlzCj4gaW50ZXJydXB0aW9uLgo+IAo+IFNvIGxl dCdzIGRpc2FibGUgUFNSIGFzIGl0IGlzIGEgaGludCB0aGF0IHRoZXJlIGlzIHByb2JsZW0gd2l0 aCB0aGlzCj4gc2luay4KPiAKPiBUaGUgcmVtb3ZlZCBGSVhNRSB3YXMgYXNraW5nIHRvIG1hbnVh bGx5IHRyYWluIHRoZSBsaW5rIGJ1dCB3ZSBkb24ndAo+IG5lZWQgdG8gZG8gdGhhdCBhcyBieSBz cGVjIHNpbmsgc2hvdWxkIGRvIGEgc2hvcnQgcHVsc2Ugd2hlbiBpdCBpcwo+IG91dCBvZiBzeW5j IHdpdGggc291cmNlLCB3ZSBqdXN0IG5lZWQgdG8gbWFrZSBzdXJlIGl0IGlzIGF3YWtlbiBhbmQK PiB0aGUgU0RQIGhlYWRlciB3aXRoIFBTUiBkaXNhYmxlIHdpbGwgdHJpZ2dlciB0aGlzIGNvbmRp dGlvbi4KPiAKPiBDYzogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBp bnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5z b3V6YUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2Lmgg IHwgIDEgKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYyB8IDM5ICsrKysrKysr KysrKysrKysrKysrKysrKysrKysKPiAtLS0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgMzYgaW5zZXJ0 aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kcnYuaAo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IGlu ZGV4IDMwMTdlZjAzN2ZlZC4uZThiYTAwZGQyYzUxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5oCj4gQEAgLTYzOCw2ICs2MzgsNyBAQCBzdHJ1Y3QgaTkxNV9wc3Igewo+ICAJdTggc2lua19z eW5jX2xhdGVuY3k7Cj4gIAlrdGltZV90IGxhc3RfZW50cnlfYXR0ZW1wdDsKPiAgCWt0aW1lX3Qg bGFzdF9leGl0Owo+ICsJdTMyIGlycV9hdXhfZXJyb3I7Cj4gIH07Cj4gIAo+ICBlbnVtIGludGVs X3BjaCB7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jCj4g Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9wc3IuYwo+IGluZGV4IDcwZDRlMjZlMTdiNS4u YWQwOTEzMGNiNGFkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bz ci5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMKPiBAQCAtMTU5LDEw ICsxNTksMTYgQEAgdm9pZCBpbnRlbF9wc3JfaXJxX2hhbmRsZXIoc3RydWN0Cj4gZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsIHUzMiBwc3JfaWlyKQo+ICAJCQkgICAgICAgQklUKFRSQU5TQ09E RVJfQyk7Cj4gIAo+ICAJZm9yX2VhY2hfY3B1X3RyYW5zY29kZXJfbWFza2VkKGRldl9wcml2LCBj cHVfdHJhbnNjb2RlciwKPiB0cmFuc2NvZGVycykgewo+IC0JCS8qIEZJWE1FOiBFeGl0IFBTUiBh bmQgbGluayB0cmFpbiBtYW51YWxseSB3aGVuIHRoaXMKPiBoYXBwZW5zLiAqLwo+IC0JCWlmIChw c3JfaWlyICYgRURQX1BTUl9FUlJPUihjcHVfdHJhbnNjb2RlcikpCj4gLQkJCURSTV9ERUJVR19L TVMoIlt0cmFuc2NvZGVyICVzXSBQU1IgYXV4Cj4gZXJyb3JcbiIsCj4gLQkJCQkgICAgICB0cmFu c2NvZGVyX25hbWUoY3B1X3RyYW5zY29kZXIpKTsKPiArCQlpZiAocHNyX2lpciAmIEVEUF9QU1Jf RVJST1IoY3B1X3RyYW5zY29kZXIpKSB7Cj4gKwkJCURSTV9XQVJOKCJbdHJhbnNjb2RlciAlc10g UFNSIGF1eCBlcnJvclxuIiwKPiArCQkJCSB0cmFuc2NvZGVyX25hbWUoY3B1X3RyYW5zY29kZXIp KTsKRG93bmdyYWRlIHRoaXMgdG8gZGVidWcgc2luY2UgdGhlIGVycm9yIGlzIGhhbmRsZWQgaW4g dGhlIGRyaXZlcj8gCgo+ICsKPiArCQkJc3Bpbl9sb2NrKCZkZXZfcHJpdi0+aXJxX2xvY2spOwo+ ICsJCQlkZXZfcHJpdi0+cHNyLmlycV9hdXhfZXJyb3IgfD0KPiBCSVQoY3B1X3RyYW5zY29kZXIp OwpKdXN0IGlnbm9yZSB0aGUgbm9uIGVEUCBiaXRzLCBJIGRvbid0IHRoaW5rIHdlIHdhbnQgdG8g ZG8gYW55dGhpbmcgd2l0aAp0aGUgaW5mb3JtYXRpb24gdGhhdCBzb21lIG90aGVyIGJpdCB3YXMg c2V0LgoKPiArCQkJc3Bpbl91bmxvY2soJmRldl9wcml2LT5pcnFfbG9jayk7Cj4gKwo+ICsJCQlz Y2hlZHVsZV93b3JrKCZkZXZfcHJpdi0+cHNyLndvcmspOwo+ICsJCX0KPiAgCj4gIAkJaWYgKHBz cl9paXIgJiBFRFBfUFNSX1BSRV9FTlRSWShjcHVfdHJhbnNjb2RlcikpIHsKPiAgCQkJZGV2X3By aXYtPnBzci5sYXN0X2VudHJ5X2F0dGVtcHQgPSB0aW1lX25zOwo+IEBAIC04OTMsMTEgKzg5OSwz NiBAQCBpbnQgaW50ZWxfcHNyX3NldF9kZWJ1Z2ZzX21vZGUoc3RydWN0Cj4gZHJtX2k5MTVfcHJp dmF0ZSAqZGV2X3ByaXYsCj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gIAo+ICtzdGF0aWMgdm9pZCBp bnRlbF9wc3JfaGFuZGxlX2lycShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4g K3sKPiArCXN0cnVjdCBpOTE1X3BzciAqcHNyID0gJmRldl9wcml2LT5wc3I7Cj4gKwl1MzIgaXJx X2F1eF9lcnJvcjsKPiArCj4gKwlzcGluX2xvY2tfaXJxKCZkZXZfcHJpdi0+aXJxX2xvY2spOwo+ ICsJaXJxX2F1eF9lcnJvciA9IHBzci0+aXJxX2F1eF9lcnJvcjsKPiArCXBzci0+aXJxX2F1eF9l cnJvciA9IDA7CkEgc3Vic2VxdWVudCBtb2Rlc2V0IHdpbGwgZW5hYmxlIFBTUiBhZ2Fpbi4gSSBk b24ndCBleHBlY3QgYSBtb2Rlc2V0IHRvCnRvIGJlIGFibGUgdG8gZml4IGFuIEFVWCB3YWtlIHVw IGZhaWx1cmUsIHNvIG1pZ2h0IGFzIHdlbGwgZGlzYWJsZSBpdApmb3IgZ29vZC4KCj4gKwlzcGlu X3VubG9ja19pcnEoJmRldl9wcml2LT5pcnFfbG9jayk7Cj4gKwo+ICsJLyogcmlnaHQgbm93IFBT UiBpcyBvbmx5IGVuYWJsZWQgaW4gZURQICovCiJyaWdodCBub3ciIGltcGxpZXMgdGhhdCBQU1Ig Y291bGQgYmUgZW5hYmxlZCBmb3Igbm9uIGVEUCBwb3J0cywgYnV0CnRoYXQncyBub3QgdGhlIGNh c2UuCgoKPiArCVdBUk5fT04oaXJxX2F1eF9lcnJvciAmIH5CSVQoVFJBTlNDT0RFUl9FRFApKTsK VGhpcyBzaG91bGQgZ28gYXdheSBpZiB5b3UgaWdub3JlIG5vbi1FRFAgYml0cywgYW5kIGEgc3Rh Y2sgdHJhY2UgaXNuJ3QKcGFydGljdWxhcmx5IHVzZWZ1bCBhbnl3YXkuCgo+ICsKPiArCW11dGV4 X2xvY2soJnBzci0+bG9jayk7CklzIHRoaXMgc3VmZmljaWVudD8gRG9uJ3Qgd2UgaGF2ZSB0byBz ZXJpYWxpemUgYWdhaW5zdCBvbmdvaW5nIG1vZGVzZXRzCmxpa2Ugd2UgZG8gZm9yIGRlYnVnZnMg ZW5hYmxlL2Rpc2FibGUuIFRoZSBkaXNhYmxlIHNlcXVlbmNlIGluIGJzcGVjCmNhbGxzIG91dCBh IHJ1bm5pbmcgcGlwZSBhbmQgcG9ydCBhcyBwcmUtcmVxdWlzaXRlcy4KCkNjaW5nIFZpbGxlIGFu ZCBNYWFydGVuIHRvIGdldCB0aGVpciBvcGluaW9uIG9uIHRoaXMuCiAKPiArCj4gKwlpbnRlbF9w c3JfZGlzYWJsZV9sb2NrZWQocHNyLT5kcCk7Cj4gKwkvKiBsZXQncyBtYWtlIHN1cmUgdGhhdCBz aW5rIGlzIGF3YWtlbiAqLwo+ICsJZHJtX2RwX2RwY2Rfd3JpdGViKCZwc3ItPmRwLT5hdXgsIERQ X1NFVF9QT1dFUiwKPiBEUF9TRVRfUE9XRVJfRDApOwpHaXZlbiB0aGF0IHRoZSBoYXJkd2FyZSBp bml0aWF0ZWQgQVVYIHdyaXRlIGZhaWxlZCwgSSB3b3VsZCByZWNvbW1lbmQKcmVhZGluZyBiYWNr IHRoZSBzaW5rIFBTUiBzdGF0dXMgdG8gbWFrZSBzdXJlIGRpc2FibGUgd29ya2VkLgoKPiArCj4g KwltdXRleF91bmxvY2soJmRldl9wcml2LT5wc3IubG9jayk7Cj4gK30KPiArCj4gIHN0YXRpYyB2 b2lkIGludGVsX3Bzcl93b3JrKHN0cnVjdCB3b3JrX3N0cnVjdCAqd29yaykKPiAgewo+ICAJc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0KPiAgCQljb250YWluZXJfb2Yod29yaywg dHlwZW9mKCpkZXZfcHJpdiksIHBzci53b3JrKTsKPiAgCj4gKwlpZiAoUkVBRF9PTkNFKGRldl9w cml2LT5wc3IuaXJxX2F1eF9lcnJvcikpCj4gKwkJaW50ZWxfcHNyX2hhbmRsZV9pcnEoZGV2X3By aXYpOwpJZiBwc3Jfd29yaygpIHdhcyBhbHJlYWR5IGV4ZWN1dGluZyBhbmQgcGFzdCB0aGlzIGNo ZWNrLApzY2hlZHVsZV93b3JrKCkgaW4gaW50ZWxfcHNyX2lycV9oYW5kbGVyIHdpbGwgcmV0dXJu IGEgZmFpbHVyZSBhbmQKZGlzYWJsZSBQU1Igd291bGQgbm93IGRlcGVuZCBvbiBnZXR0aW5nIGFu IGludmFsaWRhdGUgYW5kIGZsdXNoCm9wZXJhdGlvbi4gV2Ugc2hvdWxkIGRpc2FibGUgUFNSIHdp dGhvdXQgYW55IGRlcGVuZGVuY3kgb24gZmx1c2ggb3IKaW52YWxpZGF0ZS4KCgo+ICsKPiAgCW11 dGV4X2xvY2soJmRldl9wcml2LT5wc3IubG9jayk7Cj4gIAo+ICAJaWYgKCFkZXZfcHJpdi0+cHNy LmVuYWJsZWQpCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK