From: "flichtenheld (Code Review)" Date: Mon, 4 Aug 2025 12:14:50 +0000 References: Reply-To: frank@...2641..., arne-openvpn@...1227..., openvpn-devel@lists.sourceforge.net Message-ID: <54319d258ebb8514212390b37a633e56abbd232c-HTML@...2715...> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Disposition: inline Content-Type: multipart/alternative; boundary="lSrh0K0Nj8Q="; charset=UTF-8 Subject: [Openvpn-devel] [XS] Change in openvpn[master]: GHA: enable -Werror for mbedTLS v3 and AWS LC builds List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: plaisthos Cc: openvpn-devel --lSrh0K0Nj8Q= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Attention is currently required from: plaisthos. Hello plaisthos, I'd like you to do a code review. Please visit http://gerrit.openvpn.net/c/openvpn/+/1128?usp=3Demail to review the following change. Change subject: GHA: enable -Werror for mbedTLS v3 and AWS LC builds ...................................................................... GHA: enable -Werror for mbedTLS v3 and AWS LC builds Because we can and so we should. Change-Id: I9159e2e354170ad6dbed5a6ce620f57fa8ab128e Signed-off-by: Frank Lichtenheld --- M .github/workflows/build.yaml 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/28/1128/1 diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index cc17fba..0f88d0c 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -425,7 +425,7 @@ - name: autoconf run: autoreconf -fvi - name: configure - run: ./configure --with-crypto-library=3Dmbedtls + run: ./configure --with-crypto-library=3Dmbedtls --enable-werror - name: make all run: make -j3 - name: configure checks @@ -489,7 +489,7 @@ OPENSSL_CFLAGS=3D"-I/${{ env.AWS_LC_INSTALL }}/include" \ OPENSSL_LIBS=3D"-L/${{ env.AWS_LC_INSTALL }}/lib -lssl -lcrypto"= \ LDFLAGS=3D"-Wl,-rpath=3D/${{ env.AWS_LC_INSTALL }}/lib" \ - ./configure --with-crypto-library=3Dopenssl + ./configure --with-crypto-library=3Dopenssl --enable-werror - name: make all run: make -j3 - name: configure checks -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1128?usp=3Demail To unsubscribe, or for help writing mail filters, visit http://gerrit.openv= pn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9159e2e354170ad6dbed5a6ce620f57fa8ab128e Gerrit-Change-Number: 1128 Gerrit-PatchSet: 1 Gerrit-Owner: flichtenheld Gerrit-Reviewer: plaisthos Gerrit-CC: openvpn-devel Gerrit-Attention: plaisthos Gerrit-MessageType: newchange --lSrh0K0Nj8Q= Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Attention is currently required from: plaisthos.

flichtenheld would like plaisthos to review this change.

V= iew Change

GHA: enable -Werror for mbedTLS v3 and AWS LC builds

= Because we can and so we should.

Change-Id: I9159e2e354170ad6dbed5a6= ce620f57fa8ab128e
Signed-off-by: Frank Lichtenheld <frank@...2641...&= gt;
---
M .github/workflows/build.yaml
1 file changed, 2 insertion= s(+), 2 deletions(-)

git pull ssh://gerrit.openvpn.net:29418/open=
vpn refs/changes/28/1128/1
diff --git a/.github/workflows/build.yam=
l b/.github/workflows/build.yaml
index cc17fba..0f88d0c 100= 644
--- a/.github/workflows/build.yaml
+++ = b/.github/workflows/build.yaml
@@ -425,7 +425,7 @@ - name: autoconf
run: autoreconf -f= vi
- name: configure
- run: ./configure --with-crypto-library=3Dmbed= tls
+ run: ./c= onfigure --with-crypto-library=3Dmbedtls --enable-werror
= - name: make all
run: make -j3
- name: configure checks
@@ -489,7 +489,7 @@
OPENSSL_CFLAGS=3D"-I/${{ env.AWS_LC_INSTALL }}/i= nclude" \
OPENSSL_LIBS=3D"-L/${{ env.A= WS_LC_INSTALL }}/lib -lssl -lcrypto" \
LDFL= AGS=3D"-Wl,-rpath=3D/${{ env.AWS_LC_INSTALL }}/lib" \
<= span style=3D"color: hsl(0, 100%, 40%);">- ./configure --with-cryp= to-library=3Dopenssl

= + ./configure --with-crypto-library=3Dopenssl --enable-werror

- name: make all
run: make -j3<= /span>
- name: configure checks

=

To view, visit change 1128. To unsubscribe, or for help writing mail f= ilters, visit settings.<= /p>

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I9159e2e354170ad6dbed5a6ce62= 0f57fa8ab128e
Gerrit-Change-Number: 1128
Gerrit-PatchSet: 1
Gerrit-Owner: flichtenheld <frank@...2723...= .>
Gerrit-Reviewer: plaisthos <arne-openvpn@...1186...= .1227...>
Gerrit-CC: openvpn-devel <openvpn-devel@...1484...= ts.sourceforge.net>
Gerrit-Attention: plaisthos <arne-openvpn@...220...= ..1227...>
Gerrit-MessageType: newchange
--lSrh0K0Nj8Q=--