Message-ID: <543D807A.6000704@msgid.tls.msk.ru>
Date: Tue, 14 Oct 2014 21:58:50 +0200
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <5439399D.4020004@gmail.com> <54393AF0.1010708@gmail.com>
	<CAFEAcA_c7FE93J_7ZTqZaMG3V6Xx+EW6kAYF6XBqO9YL28+1mg@mail.gmail.com>
In-Reply-To: <CAFEAcA_c7FE93J_7ZTqZaMG3V6Xx+EW6kAYF6XBqO9YL28+1mg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] libvixl: a64: Skip
 "-Wunused-variable" for gcc 5.0.0 or higher
To: Peter Maydell <peter.maydell@linaro.org>, Chen Gang <gang.chen.5i5j@gmail.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, qemu-devel <qemu-devel@nongnu.org>, Richard Henderson <rth@twiddle.net>

On 11.10.2014 23:25, Peter Maydell wrote:
> On 11 October 2014 15:13, Chen Gang <gang.chen.5i5j@gmail.com> wrote:
>
> MJT: please don't put this in -trivial, it will clash with
> the update to libvixl 1.6 currently on the list.

Actually I'd not put that to anywhere anyway.  Because to me,
*especially* in a case like this when the code is imported from
some other place and will be updated later (so we should not
modify it), this issue can be more easily dealt with externally,
by adding a compiler option in a Makefile.  Provided, ofcourse,
that it is not fixed upstream properly to start with - and if
it is (and this is the very sane way to go really, to fix it
upstream), that fix can be pulled to qemu as well, so no
clashes with further upstream changes will happen.

And aso because really, this prob should be fixed properly, not
worked around like this..

[]
> Some other approaches to this that would confine the
> fix to the makefiles rather than requiring us to modify
> the vixl source itself:
>   a) add a -Wno- option for the affected .o files
>   b) use -isystem rather than -I to include the libvixl
>      directory on the include path
>
> (a)'s probably better I guess.

That's what I'm after too (after trying to fix it properly).
And no, at this time I dont know how gcc5 handles this.

Thanks,

/mjt