From: David Vrabel Subject: Re: [Xen-devel] [PATCH V2] xen: avoid race in p2m handling Date: Fri, 17 Oct 2014 13:35:18 +0100 Message-ID: <54410D06.3010109@citrix.com> References: <1413544566-12250-1-git-send-email-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1413544566-12250-1-git-send-email-jgross@suse.com> Sender: linux-kernel-owner@vger.kernel.org To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, konrad.wilk@oracle.com, david.vrabel@citrix.com List-Id: xen-devel@lists.xenproject.org On 17/10/14 12:16, Juergen Gross wrote: > When a new p2m leaf is allocated this leaf is linked into the p2m tree > via cmpxchg. Unfortunately the compare value for checking the success > of the update is read after checking for the need of a new leaf. It is > possible that a new leaf has been linked into the tree concurrently > in between. This could lead to a leaked memory page and to the loss of > some p2m entries. > > Avoid the race by using the read compare value for checking the need > of a new p2m leaf and use ACCESS_ONCE() to get it. > > There are other places which seem to need ACCESS_ONCE() to ensure > proper operation. Change them accordingly. Applied, thanks. David