From: dinguyen@opensource.altera.com (Dinh Nguyen) Date: Tue, 21 Oct 2014 13:48:39 -0500 Subject: [PATCHv3 1/2] ARM: dts: socfpga: Fix SD card detect In-Reply-To: <20141021171033.GK10262@pengutronix.de> References: <1413908111-28165-1-git-send-email-dinguyen@opensource.altera.com> <1413908111-28165-2-git-send-email-dinguyen@opensource.altera.com> <20141021171033.GK10262@pengutronix.de> Message-ID: <5446AA87.8070307@opensource.altera.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/21/2014 12:10 PM, Steffen Trumtrar wrote: > Hi! > > On Tue, Oct 21, 2014 at 11:15:10AM -0500, dinguyen at opensource.altera.com wrote: >> From: Dinh Nguyen >> >> Without this patch, the booting the SOCFPGA platform would hang at the >> SDMMC driver loading. The issue, debugged by Doug Anderson, turned out >> to be that the GPIO bank used by the SD card-detect was not set to >> status="okay". >> >> Suggested-by: Doug Anderson >> Signed-off-by: Dinh Nguyen >> --- >> v3: Correctly degugged the issue to be a gpio node not having status="okay" >> --- >> arch/arm/boot/dts/socfpga_cyclone5_socdk.dts | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts >> index d7296a5..03a3745 100644 >> --- a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts >> +++ b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts >> @@ -37,6 +37,12 @@ >> */ >> ethernet0 = &gmac1; >> }; >> + >> + soc { >> + gpio at ff709000 { >> + status = "okay"; >> + }; >> + }; >> }; >> > > Looks weird. Don't you need to enable the GPIO bank instead: > > &gpio1 { > status = "okay"; > } > No, this will not work as gpio1 is already a node inside gpio at ff709000. The reason for this was that the Designware GPIO IP can support 1, 2 or 3 gpio ports of varying widths. [1][2] Dinh [1] http://article.gmane.org/gmane.linux.drivers.devicetree/72771/match=dw+apb+gpio [2] http://article.gmane.org/gmane.linux.kernel/1671576/match=dw+apb+gpio