Message-ID: <5448539F.6030300@huawei.com>
Date: Thu, 23 Oct 2014 09:02:23 +0800
From: Gonglei <arei.gonglei@huawei.com>
MIME-Version: 1.0
References: <201410211604116199416@sangfor.com> <5446265E.306@redhat.com>
	<54482D38.5080904@redhat.com>
In-Reply-To: <54482D38.5080904@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] snapshot: use local variable to
 bdrv_pwrite_sync L1 table
To: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-trivial <qemu-trivial@nongnu.org>, qemu-devel <qemu-devel@nongnu.org>, Max Reitz <mreitz@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Zhang Haoyu <zhanghy@sangfor.com>

On 2014/10/23 6:18, Eric Blake wrote:

> On 10/21/2014 03:24 AM, Max Reitz wrote:
>> On 2014-10-21 at 10:04, Zhang Haoyu wrote:
>>> Use local variable to bdrv_pwrite_sync L1 table,
>>> needless to make conversion of cached L1 table between
>>> big-endian and host style.
>>>
>>> Signed-off-by: Zhang Haoyu <zhanghy@sangfor.com>
>>> ---
>>>   block/qcow2-refcount.c | 22 +++++++---------------
>>>   1 file changed, 7 insertions(+), 15 deletions(-)
>>>
> 
> I know we're up to v5 and that Max already took it into his branch, but...
> 
> 
>>>       l1_size2 = l1_size * sizeof(uint64_t);
>>> +    l1_table = g_try_malloc0(align_offset(l1_size2, 512));
>>
>> I wanted to propose using qemu_try_blockalign(), but since it'd require
>> a memset() afterwards, it gets rather ugly.
> 
> Not after this recent patch:
> 
> https://lists.gnu.org/archive/html/qemu-devel/2014-10/msg02499.html
> 

Good catch :)

Best regards,
-Gonglei