Received: from eggs.gnu.org ([2001:4830:134:3::10]:34063)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1XhCD0-0001vu-65
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 02:49:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1XhCCu-0004RX-0j
	for qemu-devel@nongnu.org; Thu, 23 Oct 2014 02:49:18 -0400
Message-ID: <5448A4E5.1020605@msgid.tls.msk.ru>
Date: Thu, 23 Oct 2014 10:49:09 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <54369514.5000004@gmail.com>
	<CAFEAcA9KgX1gOtXPqTC2gX1HD69aPF9fbKkk1i5zbN2+tLW_og@mail.gmail.com>
In-Reply-To: <CAFEAcA9KgX1gOtXPqTC2gX1HD69aPF9fbKkk1i5zbN2+tLW_og@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH]
 disas/libvixl/a64/instructions-a64.h: Remove useless varialbe to avoid
 building break with '-Werror'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, Chen Gang <gang.chen.5i5j@gmail.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, qemu-devel <qemu-devel@nongnu.org>, "rth@twiddle.net" <rth@twiddle.net>

On 10/21/2014 07:50 PM, Peter Maydell wrote:
> On 9 October 2014 15:00, Chen Gang <gang.chen.5i5j@gmail.com> wrote:
[]
>> --- a/disas/libvixl/a64/instructions-a64.h
>> +++ b/disas/libvixl/a64/instructions-a64.h
>> @@ -95,30 +95,6 @@ const unsigned kDoubleExponentBits = 11;
>>  const unsigned kFloatMantissaBits = 23;
>>  const unsigned kFloatExponentBits = 8;
>>
>> -const float kFP32PositiveInfinity = rawbits_to_float(0x7f800000);
>> -const float kFP32NegativeInfinity = rawbits_to_float(0xff800000);
...

> Upstream's plan for fixing this is to turn these into
> 'extern const double foo' in the header with the definition
> in an appropriate .cc file. Given that, I think I'm happy for
> us to take this patch in QEMU for the moment, with the expectation
> that the next libvixl drop will just obsolete it.

If upstream already have a patch for this, why not take the
upstream's solution now, so we wont need to revert our solution
before applying next drop from upstream?

BTW, how the "upstream drop" is done, anyway?  If it is something
like git merge, we may need to care, but if it is just cp -a upstream/* .
when there's no reason to... ;)

Thanks,

/mjt