From: Andres Rodriguez Subject: RE: [PATCH 4/8] drm/amdgpu: convert kiq ring_mutex to a spinlock Date: Mon, 8 May 2017 15:41:59 +0000 Message-ID: <544E607D03B20249AA404517E498FC469FE655@exchange01.valvesoftware.com> References: <20170505171015.4672-1-andresx7@gmail.com> <20170505171015.4672-5-andresx7@gmail.com> , Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: "Liu, Monk" , Andres Rodriguez , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" CgpPbiAyMDE3LTA1LTA4IDAyOjA4IEFNLCBMaXUsIE1vbmsgd3JvdGU6Cj4gQW5kcmVzCj4gCj4g U29tZSBwcmV2aW91cyBwYXRjaGVzIGxpa2UgbW92ZSBLSVEgbXV0ZXgtbG9jayBmcm9tIGFtZGdw dV92aXJ0IHRvIGNvbW1vbiBwbGFjZSBqdW1wZWQgbXkgTkFLLCBidXQgZnJvbSB0ZWNobmlxdWUg cGVyc3BlY3RpdmUgaXQncyBubyBtYXR0ZXIgYW55d2F5LCAKPiBCdXQgdGhpcyBwYXRjaCBhbmQg dGhlIGZvbGxvd2luZyBwYXRjaGVzIGFyZSBnbyB0byBhIGRlYWQgZW5kLCAgCj4gCj4gMSwgRG9u J3QgdXNlIEtJUSB0byBhY2Nlc3MgcmVnaXN0ZXIgaW5zaWRlIElOVFIgY29udGV4dCAuLi4KClRo aXMgaXMgZXhwbGFpbmVkIGJlbG93LgoKPiAyLCBEb24ndCBzdWJtaXQgQ1AvaHcgYmxvY2tpbmcg am9icyBvbiBLSVEgc2luY2UgdGhleSB3aWxsIHByZXZlbnQgd29ybGQgc3dpdGNoLAoKT25seSBX UklURV9EQVRBIHBhY2tldHMgYXJlIGJlaW5nIHN1Ym1pdHRlZC4gVGhlcmUgaXMgbm8gYmxvY2tp bmcgd29yayB0aGF0IHdvdWxkIHByZXZlbnQgYSB3b3JsZHN3aXRjaC4KCj4gCj4gQmVzaWRlcywg d2h5IG5vdCB1c2UgTUVDMiBQSVBFMSBxdWV1ZTEgdG8gc2VydmUgeW91ciBwdXJwb3NlID8gIGlm IHlvdSBpbnNpc3QgdG8gZG8gYWJvdmUgdGhpbmdzIGluIEtJUT8KPiBBbnkgcmVhc29uIHlvdSBt dXN0IHVzZSBLSVEgPwoKSGF2aW5nIGEgc2VwYXJhdGUgS0lRIGZvciBiYXJlLW1ldGFsIGFtZGdw dSBhbmQgdmlydHVhbGl6ZWQgYW1kZ3B1IHNvdW5kcyBnb29kIGF0IGZhY2UtdmFsdWUuIEhvd2V2 ZXIsIEknbSBub3Qgc3VyZSBpZiBpdCB3b3VsZCBpbnRyb2R1Y2Ugc3VidGxlIHN5bmNocm9uaXph dGlvbiBidWdzIGlmIGJvdGggcGlwZXMgYXR0ZW1wdCB0byB0b3VjaCB0aGUgc2FtZSBIVyByZXNv dXJjZXMgc2ltdWx0YW5lb3VzbHkuCgpDYW4geW91IGV4cGxhaW4geW91ciByZWFzb25pbmcgYmVo aW5kIHlvdXIgY3VycmVudCBwb3NpdGlvbiB0aGF0IHRoZSBLSVEgc2hvdWxkbid0IGJlIHVzZWQg YnkgYmFyZW1ldGFsIGFtZGdwdT8KCj4gCj4gCj4gQlIKPiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2Ut LS0tLQo+IEZyb206IGFtZC1nZnggW21haWx0bzphbWQtZ2Z4LWJvdW5jZXNAbGlzdHMuZnJlZWRl c2t0b3Aub3JnXSBPbiBCZWhhbGYgT2YgTGl1LCBNb25rCj4gU2VudDogTW9uZGF5LCBNYXkgMDgs IDIwMTcgMTo1OSBQTQo+IFRvOiBBbmRyZXMgUm9kcmlndWV6IDxhbmRyZXN4N0BnbWFpbC5jb20+ OyBhbWQtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IFN1YmplY3Q6IFJFOiBbUEFUQ0ggNC84 XSBkcm0vYW1kZ3B1OiBjb252ZXJ0IGtpcSByaW5nX211dGV4IHRvIGEgc3BpbmxvY2sKPiAKPiBD bGVhcmx5IE5BSwo+IAo+IAltdXRleF9sb2NrKCZraXEtPnJpbmdfbXV0ZXgpOwo+IAlhbWRncHVf cmluZ19hbGxvYyhyaW5nLCAzMik7Cj4gCWFtZGdwdV9yaW5nX2VtaXRfcnJlZyhyaW5nLCByZWcp Owo+IAlhbWRncHVfZmVuY2VfZW1pdChyaW5nLCAmZik7Cj4gCWFtZGdwdV9yaW5nX2NvbW1pdChy aW5nKTsKPiAJbXV0ZXhfdW5sb2NrKCZraXEtPnJpbmdfbXV0ZXgpOwo+IAo+IAo+IGJlIGF3YXJl IHRoYXQgYW1kZ3B1X2ZlbmNlX2VtaXQoKSBpbnRyb2R1Y2VzIGZlbmNlX3dhaXQoKSBvcGVyYXRp b24sCgpQbGVhc2Ugc2VlIHRoZSBmb2xsb3dpbmcgcGF0Y2g6CltQQVRDSCA2LzhdIGRybS9hbWRn cHU6IGFkZCBtYWNybyBmb3IgYXN5bmNocm9ub3VzIEtJUSByZWdpc3RlciB3cml0ZXMKClRoaXMg aXMgd2h5IHRoaXMgcGF0Y2ggaXMgZGVzY3JpYmVkIGFzICJzdGVwIG9uZSIKCj4gc3Bpbl9sb2Nr IGlzIGZvcmJpZGRlbiBhbmQgd2h5IHlvdSB3YW50IHRvIHVzZSBzcGlubG9jayBpbnN0ZWFkIG9m IG11dGV4LCBwbGVhc2UgZ2l2ZSB0aGUgZXhwbGFuYXRpb24gCgpJIGRvbid0IHVuZGVyc3RhbmQg d2hhdCB5b3UgbWVhbiBieSBzcGluX2xvY2sgYmVpbmcgZm9yYmlkZGVuLiBUaGUgc3Bpbl9sb2Nr IGlzIGEgc3RhbmRhcmQga2VybmVsIGNvbnN0cnVjdCBzcGVjaWZpY2FsbHkgZGVzaWduZWQgdG8g YWRkcmVzcyBtdXR1YWwgZXhjbHVzaW9uIGluIGNvbnRleHRzIHRoYXQgZGlzYWxsb3cgc2xlZXBp bmcuIFRoYXQgaXMgZXhhY3RseSB3aGF0IHdlIGFyZSB0cnlpbmcgdG8gZG8gaGVyZSwgYXMgZGVz Y3JpYmVkIGluIHRoZSBjb21taXQgbWVzc2FnZS4KClJlZ2FyZHMsCkFuZHJlcwoKPiAKPiBCUiBN b25rCj4gCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiBGcm9tOiBhbWQtZ2Z4IFttYWls dG86YW1kLWdmeC1ib3VuY2VzQGxpc3RzLmZyZWVkZXNrdG9wLm9yZ10gT24gQmVoYWxmIE9mIEFu ZHJlcyBSb2RyaWd1ZXoKPiBTZW50OiBTYXR1cmRheSwgTWF5IDA2LCAyMDE3IDE6MTAgQU0KPiBU bzogYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogYW5kcmVzeDdAZ21haWwuY29t Cj4gU3ViamVjdDogW1BBVENIIDQvOF0gZHJtL2FtZGdwdTogY29udmVydCBraXEgcmluZ19tdXRl eCB0byBhIHNwaW5sb2NrCj4gCj4gRmlyc3Qgc3RlcCB0b3dhcmRzIGVuYWJsaW5nIGtpcSByZWdp c3RlciBvcGVyYXRpb25zIGZyb20gYW4gaW50ZXJydXB0IGhhbmRsZXIKPiAKPiBTaWduZWQtb2Zm LWJ5OiBBbmRyZXMgUm9kcmlndWV6IDxhbmRyZXN4N0BnbWFpbC5jb20+Cj4gLS0tCj4gIGRyaXZl cnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oICAgICAgICB8ICAyICstCj4gIGRyaXZlcnMv Z3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdV9kZXZpY2UuYyB8IDEwICsrKysrLS0tLS0KPiAgMiBm aWxlcyBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oIGIvZHJpdmVycy9ncHUv ZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmgKPiBpbmRleCA0OTZhZDY2Li4xZDk4N2UzIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdwdS5oCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1LmgKPiBAQCAtOTQxLDcgKzk0MSw3IEBAIHN0cnVj dCBhbWRncHVfa2lxIHsKPiAgCXN0cnVjdCBhbWRncHVfcmluZwlyaW5nOwo+ICAJc3RydWN0IGFt ZGdwdV9pcnFfc3JjCWlycTsKPiAgCXVpbnQzMl90CQlyZWdfdmFsX29mZnM7Cj4gLQlzdHJ1Y3Qg bXV0ZXgJCXJpbmdfbXV0ZXg7Cj4gKwlzcGlubG9ja190CQlyaW5nX2xvY2s7Cj4gIH07Cj4gIAo+ ICAvKgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2 aWNlLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHVfZGV2aWNlLmMKPiBpbmRl eCBlZjNhNDZkLi5jZTIyZjA0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1k Z3B1L2FtZGdwdV9kZXZpY2UuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2Ft ZGdwdV9kZXZpY2UuYwo+IEBAIC0xNjksMTIgKzE2OSwxMiBAQCB1aW50MzJfdCBhbWRncHVfa2lx X3JyZWcoc3RydWN0IGFtZGdwdV9kZXZpY2UgKmFkZXYsIHVpbnQzMl90IHJlZykKPiAgCj4gIAlC VUdfT04oIXJpbmctPmZ1bmNzLT5lbWl0X3JyZWcpOwo+ICAKPiAtCW11dGV4X2xvY2soJmtpcS0+ cmluZ19tdXRleCk7Cj4gKwlzcGluX2xvY2soJmtpcS0+cmluZ19sb2NrKTsKPiAgCWFtZGdwdV9y aW5nX2FsbG9jKHJpbmcsIDMyKTsKPiAgCWFtZGdwdV9yaW5nX2VtaXRfcnJlZyhyaW5nLCByZWcp Owo+ICAJYW1kZ3B1X2ZlbmNlX2VtaXQocmluZywgJmYpOwo+ICAJYW1kZ3B1X3JpbmdfY29tbWl0 KHJpbmcpOwo+IC0JbXV0ZXhfdW5sb2NrKCZraXEtPnJpbmdfbXV0ZXgpOwo+ICsJc3Bpbl91bmxv Y2soJmtpcS0+cmluZ19sb2NrKTsKPiAgCj4gIAlyID0gZG1hX2ZlbmNlX3dhaXQoZiwgZmFsc2Up Owo+ICAJaWYgKHIpCj4gQEAgLTE5NSwxMiArMTk1LDEyIEBAIHZvaWQgYW1kZ3B1X2tpcV93cmVn KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LCB1aW50MzJfdCByZWcsIHVpbnQzMl90IHYpCj4g IAo+ICAJQlVHX09OKCFyaW5nLT5mdW5jcy0+ZW1pdF93cmVnKTsKPiAgCj4gLQltdXRleF9sb2Nr KCZraXEtPnJpbmdfbXV0ZXgpOwo+ICsJc3Bpbl9sb2NrKCZraXEtPnJpbmdfbG9jayk7Cj4gIAlh bWRncHVfcmluZ19hbGxvYyhyaW5nLCAzMik7Cj4gIAlhbWRncHVfcmluZ19lbWl0X3dyZWcocmlu ZywgcmVnLCB2KTsKPiAgCWFtZGdwdV9mZW5jZV9lbWl0KHJpbmcsICZmKTsKPiAgCWFtZGdwdV9y aW5nX2NvbW1pdChyaW5nKTsKPiAtCW11dGV4X3VubG9jaygma2lxLT5yaW5nX211dGV4KTsKPiAr CXNwaW5fdW5sb2NrKCZraXEtPnJpbmdfbG9jayk7Cj4gIAo+ICAJciA9IGRtYV9mZW5jZV93YWl0 KGYsIGZhbHNlKTsKPiAgCWlmIChyKQo+IEBAIC0xOTAzLDcgKzE5MDMsNiBAQCBpbnQgYW1kZ3B1 X2RldmljZV9pbml0KHN0cnVjdCBhbWRncHVfZGV2aWNlICphZGV2LAo+ICAJbXV0ZXhfaW5pdCgm YWRldi0+ZmlybXdhcmUubXV0ZXgpOwo+ICAJbXV0ZXhfaW5pdCgmYWRldi0+cG0ubXV0ZXgpOwo+ ICAJbXV0ZXhfaW5pdCgmYWRldi0+Z2Z4LmdwdV9jbG9ja19tdXRleCk7Cj4gLQltdXRleF9pbml0 KCZhZGV2LT5nZngua2lxLnJpbmdfbXV0ZXgpOwo+ICAJbXV0ZXhfaW5pdCgmYWRldi0+c3JibV9t dXRleCk7Cj4gIAltdXRleF9pbml0KCZhZGV2LT5ncmJtX2lkeF9tdXRleCk7Cj4gIAltdXRleF9p bml0KCZhZGV2LT5tbl9sb2NrKTsKPiBAQCAtMTkyMSw2ICsxOTIwLDcgQEAgaW50IGFtZGdwdV9k ZXZpY2VfaW5pdChzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRldiwKPiAgCXNwaW5fbG9ja19pbml0 KCZhZGV2LT5nY19jYWNfaWR4X2xvY2spOwo+ICAJc3Bpbl9sb2NrX2luaXQoJmFkZXYtPmF1ZGlv X2VuZHB0X2lkeF9sb2NrKTsKPiAgCXNwaW5fbG9ja19pbml0KCZhZGV2LT5tbV9zdGF0cy5sb2Nr KTsKPiArCXNwaW5fbG9ja19pbml0KCZhZGV2LT5nZngua2lxLnJpbmdfbG9jayk7Cj4gIAo+ICAJ SU5JVF9MSVNUX0hFQUQoJmFkZXYtPnNoYWRvd19saXN0KTsKPiAgCW11dGV4X2luaXQoJmFkZXYt PnNoYWRvd19saXN0X2xvY2spOwo+IC0tCj4gMi45LjMKPiAKPiBfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4gYW1k LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2FtZC1nZngKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwo+IGFtZC1nZnggbWFpbGluZyBsaXN0Cj4gYW1kLWdmeEBsaXN0 cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2FtZC1nZngKPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwphbWQtZ2Z4IG1haWxpbmcgbGlzdAphbWQtZ2Z4QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ft ZC1nZngK