Received: from eggs.gnu.org ([2001:4830:134:3::10]:50414) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkDvo-0005LG-8y for qemu-devel@nongnu.org; Fri, 31 Oct 2014 11:16:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xk4HP-0002Ag-MC for qemu-devel@nongnu.org; Fri, 31 Oct 2014 00:57:48 -0400 Message-ID: <545316A7.2010601@huawei.com> Date: Fri, 31 Oct 2014 12:57:11 +0800 From: Gonglei MIME-Version: 1.0 References: <6b6f5fbff3574bffafe4204d2153258fc4440120.1414681502.git.mjt@msgid.tls.msk.ru> In-Reply-To: <6b6f5fbff3574bffafe4204d2153258fc4440120.1414681502.git.mjt@msgid.tls.msk.ru> Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] os-posix: use global daemon_pipe instead of cryptic fds[1] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: "qemu-trivial@nongnu.org" , "qemu-devel@nongnu.org" , Markus Armbruster On 2014/10/30 23:07, Michael Tokarev wrote: > When asked to -daemonize, we fork a child and setup a pipe between > it and parent to pass exit status. os-posix.c used global fds[2] > array for that, but actually only the writing side of the pipe is > needed to be global, and this name is really too generic. Use > just one interger for the writing side of the pipe, and name it > daemon_pipe to be more understandable than cryptic fds[1]. > > Signed-off-by: Michael Tokarev > --- > os-posix.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Gonglei Best regards, -Gonglei