Received: from eggs.gnu.org ([2001:4830:134:3::10]:51545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XkDvb-0006qH-Tc for qemu-devel@nongnu.org; Fri, 31 Oct 2014 11:16:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xk4Md-000813-3T for qemu-devel@nongnu.org; Fri, 31 Oct 2014 01:03:11 -0400 Message-ID: <545317F3.9050105@huawei.com> Date: Fri, 31 Oct 2014 13:02:43 +0800 From: Gonglei MIME-Version: 1.0 References: <7bdebf1bc921df74cb0edc42d2ea77cda220074c.1414681502.git.mjt@msgid.tls.msk.ru> In-Reply-To: <7bdebf1bc921df74cb0edc42d2ea77cda220074c.1414681502.git.mjt@msgid.tls.msk.ru> Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 4/4] os-posix: reorder parent notification for -daemonize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: "qemu-trivial@nongnu.org" , "qemu-devel@nongnu.org" , Markus Armbruster On 2014/10/30 23:07, Michael Tokarev wrote: > Put "success" parent reporting in os_setup_post() to after > all other initializers which may also fail, to the very end, > so more possible failure cases are reported properly to the > calling process. > > Signed-off-by: Michael Tokarev > --- > os-posix.c | 19 ++++++++++--------- > 1 file changed, 10 insertions(+), 9 deletions(-) Reviewed-by: Gonglei Best regards, -Gonglei