From: "Jan Beulich" Subject: Re: [v2][PATCH] tools/hvmloader: link errno.h from xen internal Date: Mon, 03 Nov 2014 09:43:10 +0000 Message-ID: <54575C3E020000780004440F@mail.emea.novell.com> References: <1415005248-25620-1-git-send-email-tiejun.chen@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1415005248-25620-1-git-send-email-tiejun.chen@intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tiejun Chen Cc: Ian.Campbell@eu.citrix.com, Ian.Jackson@eu.citrix.com, xen-devel@lists.xen.org, wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org >>> On 03.11.14 at 10:00, wrote: > --- a/tools/firmware/hvmloader/Makefile > +++ b/tools/firmware/hvmloader/Makefile > @@ -84,9 +84,12 @@ ROMS += $(SEABIOS_ROM) > endif > > .PHONY: all > -all: subdirs-all > +all: subdirs-all .dir Considering uses going forward, I think subdirs-all should depend on .dir (which is being misnamed anyway, presumably due to blindly taking what is in tools/include/Makefile, where a directory _is_ being created). Considering that it's an individual file, the file name would seem quite right to be used as dependency here. Jan