From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Mon, 03 Nov 2014 18:20:00 +0100 Subject: [PATCH 03/17] irqchip: irq-armada-370-xp: use proper return value for ->set_affinity() In-Reply-To: <1414151970-6626-4-git-send-email-thomas.petazzoni@free-electrons.com> References: <1414151970-6626-1-git-send-email-thomas.petazzoni@free-electrons.com> <1414151970-6626-4-git-send-email-thomas.petazzoni@free-electrons.com> Message-ID: <5457B940.2030105@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Thomas, On 24/10/2014 13:59, Thomas Petazzoni wrote: > The ->set_affinity() hook of 'struct irq_chip' is supposed to return > one of IRQ_SET_MASK_OK or IRQ_SET_MASK_OK_NOCOPY. However, the code > currently simply returns 0. This patch fixes that by using > IRQ_SET_MASK_OK, which tells the IRQ core that it is responsible for > updating irq_data.affinity. It seems that this driver is not the only one to return 0 instead of IRQ_SET_MASK_OK in the >set_affinity(). I found also irq-xtensa-mx.c, irq-metag.c and irq-metag-ext.c. > > Note that this patch does not cause any change to the compiled code, > as IRQ_SET_MASK_OK has the value 0. This is therefore just a simple > cleanup. > > Signed-off-by: Thomas Petazzoni > Cc: Thomas Gleixner > Cc: Jason Cooper > Cc: linux-kernel at vger.kernel.org > --- > drivers/irqchip/irq-armada-370-xp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Gregory CLEMENT Thanks, Gregory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com