From: Boris Derzhavets Subject: Re: [PATCH] fs-backend: fix compile problems Date: Wed, 18 Mar 2009 07:48:34 -0700 (PDT) Message-ID: <54599.39242.qm@web56101.mail.re3.yahoo.com> References: <49C10306.3080106@eu.citrix.com> Reply-To: bderzhavets@yahoo.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0600358950==" Return-path: In-Reply-To: <49C10306.3080106@eu.citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Stefano Stabellini Cc: xen-devel List-Id: xen-devel@lists.xenproject.org --===============0600358950== Content-Type: multipart/alternative; boundary="0-457752558-1237387714=:39242" --0-457752558-1237387714=:39242 Content-Type: text/plain; charset=us-ascii Thank you. It's done Boris --- On Wed, 3/18/09, Stefano Stabellini wrote: From: Stefano Stabellini Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems To: "bderzhavets@yahoo.com" Cc: "xen-devel" Date: Wednesday, March 18, 2009, 10:19 AM Boris Derzhavets wrote: > Removed unresolved reference in > /usr/src/xen-unstable.hg/tools/ioemu-dir/vl.c:5898: undefined reference > to `pci_emulation_add' > > /* for (i = 0; i < nb_pci_emulation; i++) { > if(pci_emulation_add(pci_emulation_config_text[i]) < 0) { > fprintf(stderr, "Warning: could not add PCI device %s\n", > pci_emulation_config_text[i]); > } > } > */ > > "make tools" completed OK. > Is it acceptable ? > I think we are missing an ifdef CONFIG_PASSTHROUGH diff --git a/vl.c b/vl.c index 9b9f7d5..6c0ffb3 100644 --- a/vl.c +++ b/vl.c @@ -5894,12 +5894,14 @@ int main(int argc, char **argv, char **envp) } } +#ifdef CONFIG_PASSTHROUGH for (i = 0; i < nb_pci_emulation; i++) { if(pci_emulation_add(pci_emulation_config_text[i]) < 0) { fprintf(stderr, "Warning: could not add PCI device %s\n", pci_emulation_config_text[i]); } } +#endif if (strlen(direct_pci_str) > 0) direct_pci = direct_pci_str; _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --0-457752558-1237387714=:39242 Content-Type: text/html; charset=us-ascii
Thank you. It's done
Boris

--- On Wed, 3/18/09, Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote:
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [Xen-devel] [PATCH] fs-backend: fix compile problems
To: "bderzhavets@yahoo.com" <bderzhavets@yahoo.com>
Cc: "xen-devel" <xen-devel@lists.xensource.com>
Date: Wednesday, March 18, 2009, 10:19 AM

Boris Derzhavets wrote:

> Removed unresolved reference in
> /usr/src/xen-unstable.hg/tools/ioemu-dir/vl.c:5898: undefined reference
> to `pci_emulation_add'
>
> /* for (i = 0; i < nb_pci_emulation; i++) {
> if(pci_emulation_add(pci_emulation_config_text[i]) < 0) {
> fprintf(stderr, "Warning: could not add PCI device
%s\n",
> pci_emulation_config_text[i]);
> }
> }
> */
>
> "make tools" completed OK.
> Is it acceptable ?
>



I think we are missing an ifdef CONFIG_PASSTHROUGH


diff --git a/vl.c b/vl.c
index 9b9f7d5..6c0ffb3 100644
--- a/vl.c
+++ b/vl.c
@@ -5894,12 +5894,14 @@ int main(int argc, char **argv, char **envp)
}
}

+#ifdef CONFIG_PASSTHROUGH
for (i = 0; i < nb_pci_emulation; i++) {
if(pci_emulation_add(pci_emulation_config_text[i]) < 0) {
fprintf(stderr, "Warning: could not add PCI device
%s\n",
pci_emulation_ config_text[i]);
}
}
+#endif

if (strlen(direct_pci_str) > 0)
direct_pci = direct_pci_str;

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

--0-457752558-1237387714=:39242-- --===============0600358950== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0600358950==--