From: David Vrabel Subject: Re: [Xen-devel] [PATCH V2 2/5] xen: Delay m2p_override initialization Date: Fri, 7 Nov 2014 14:08:46 +0000 Message-ID: <545CD26E.8040404@citrix.com> References: <1415252853-7106-1-git-send-email-jgross@suse.com> <1415252853-7106-3-git-send-email-jgross@suse.com> <545CC349.8020006@citrix.com> <545CC6D8.80100@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <545CC6D8.80100@suse.com> Sender: linux-kernel-owner@vger.kernel.org To: Juergen Gross , David Vrabel , linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, konrad.wilk@oracle.com, boris.ostrovsky@oracle.com, x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com List-Id: xen-devel@lists.xenproject.org On 07/11/14 13:19, Juergen Gross wrote: > On 11/07/2014 02:04 PM, David Vrabel wrote: >> >> I suppose this is the "make some functions static" but it's an >> unreviewable mess. If you can't do this with some one line changes >> adding "static" and perhaps some forward declarations then please drop >> this bit. > > Do you really prefer forward declarations instead of pure code movement? > I can do as you request, but just want to make sure. Normally I prefer not having forward declarations... How about a patch that does this and then a 2nd patch that does the pure code motion. Maybe that will produce a better diff? You can also try the --patience option for git diff (etc.). This may produce more readable diffs. David