From: David Vrabel Subject: Re: [Xen-devel] [PATCH V3 1/8] xen: Make functions static Date: Tue, 11 Nov 2014 10:21:04 +0000 Message-ID: <5461E310.4070803@citrix.com> References: <1415684626-18590-1-git-send-email-jgross@suse.com> <1415684626-18590-2-git-send-email-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1415684626-18590-2-git-send-email-jgross@suse.com> Sender: linux-kernel-owner@vger.kernel.org To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, konrad.wilk@oracle.com, david.vrabel@citrix.com, boris.ostrovsky@oracle.com, x86@kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com List-Id: xen-devel@lists.xenproject.org On 11/11/14 05:43, Juergen Gross wrote: > Some functions in arch/x86/xen/p2m.c are used locally only. Make them > static. Rearrange the functions in p2m.c to avoid forward declarations. > > While at it correct some style issues (long lines, use pr_warn()). Please don't add extra stuff like this. In general if you feel yourself wring "while at it..." or "also..." then you need another patch. I also don't care about long lines if they are under 100 characters. David