From: David Vrabel Subject: Re: [Xen-devel] [PATCH V3 2/8] xen: Delay remapping memory of pv-domain Date: Fri, 14 Nov 2014 11:16:19 +0000 Message-ID: <5465E483.7080802@citrix.com> References: <1415684626-18590-1-git-send-email-jgross@suse.com> <1415684626-18590-3-git-send-email-jgross@suse.com> <20141112214506.GA5922@laptop.dumpdata.com> <54644E48.3040506@suse.com> <20141113195605.GA13039@laptop.dumpdata.com> <54658ABF.5050708@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <54658ABF.5050708@suse.com> Sender: linux-kernel-owner@vger.kernel.org To: Juergen Gross , Konrad Rzeszutek Wilk Cc: xen-devel@lists.xensource.com, x86@kernel.org, linux-kernel@vger.kernel.org, mingo@redhat.com, david.vrabel@citrix.com, hpa@zytor.com, boris.ostrovsky@oracle.com, tglx@linutronix.de List-Id: xen-devel@lists.xenproject.org On 14/11/14 04:53, Juergen Gross wrote: > > Using BUG() instead would make the code less complex. Do you really > think xen_update_mem_tables() would ever fail in a sane system? > > - set_phys_to_machine() would fail only on a memory shortage. Just > going on without adding more memory wouldn't lead to a healthy system, > I think. > - The hypervisor calls would fail only in case of parameter errors. > This should never happen, so dying seems to be the correct reaction. > > David, what do you think? BUG() sounds fine. David