Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C81DEB64D9 for ; Thu, 6 Jul 2023 14:07:43 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 9868E85FDD; Thu, 6 Jul 2023 16:07:41 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="Ttvps9uF"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 71FB98630D; Thu, 6 Jul 2023 16:07:40 +0200 (CEST) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A8E9E85C98 for ; Thu, 6 Jul 2023 16:07:37 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=rogerq@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 56AEE6196E; Thu, 6 Jul 2023 14:07:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29BA0C433C9; Thu, 6 Jul 2023 14:07:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688652443; bh=QEf3TQ5wxY43rvH7mvS8PYqRDJghb7S1zWoedgtmmxc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Ttvps9uFARmbYo942y7Y49IuHTwHNpI30bnpN0pphvZwz5ueYBK1cSpvxtiTNOPKG TJtHvsUBsOml1mfeDNOoiCrVdiO2yvTvqX1QZrzItGPuxt9tfaqDjcoKvnV9WNvz84 YIpms++h8aUV92Mc3EoyUvr3yZXIpZCeDk+GmIAXuwTzSgCMzGFY6yEAtbPEXgVdmA MUyoGgA6rsyPU2XfJX2ifX01R0c/dZn5A9R1XGjOxSnf3aWDtPk3+hOOo7abKEQol8 8sJFmSa0SLPTTbHra+hoSGWQgUi2zoC7fk7hBndukHyfQPoD56BYIIumdkxi8Etb6a 3ZxDMrn5++Jdg== Message-ID: <5466b71a-87a9-1c10-8b97-12dfacfee5de@kernel.org> Date: Thu, 6 Jul 2023 17:07:19 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v4 0/2] Fix 'no USB device found' error. To: Julien Panis , u-boot@lists.denx.de, Marek Vasut , trini@konsulko.com, tony@atomide.com Cc: vigneshr@ti.com, nm@ti.com References: <20230621-fix_usb_ether_init-v4-0-5f4977bb7678@baylibre.com> Content-Language: en-US From: Roger Quadros In-Reply-To: <20230621-fix_usb_ether_init-v4-0-5f4977bb7678@baylibre.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Julien, On 06/07/2023 13:40, Julien Panis wrote: > This series fixes the "No USB device found" error > for am335x-icev2 and am335x-evmsk. USB0 dual-role > feature is now handled as peripheral only in the > driver. > > The error was not produced for am335x-evm because > usb0 dr_mode was configured as peripheral in > 'am335x-evm-u-boot.dtsi'. This fragment is no > longer needed. > > Signed-off-by: Julien Panis > --- > Changes in v4: > - Handle usb dual-role feature as peripheral in ti-musb driver. > - Link to v3: https://lore.kernel.org/r/20230621-fix_usb_ether_init-v3-1-40493e1d7c0b@baylibre.com > > Changes in v3: > - Remove usb0 dr_mode configuration from 'am335x-evm-u-boot.dtsi'. > - Link to v2: https://lore.kernel.org/r/20230621-fix_usb_ether_init-v2-0-ff121f0e8d7a@baylibre.com > > Changes in v2: > - Drop the modification made in arch/arm/mach-omap2/am33xx/board.c > - Configure usb0 dr_mode as peripheral in 'am335x-icev2-u-boot.dtsi' > and 'am335x-evmsk-u-boot.dtsi' device trees. > - Link to v1: https://lore.kernel.org/r/20230621-fix_usb_ether_init-v1-1-2156923994a9@baylibre.com > > --- > Julien Panis (2): > musb-new: ti-musb: Handle usb dual-role feature as peripheral > arm: dts: am335x-evm-u-boot: Remove usb0 mode configuration for this series: Reviewed-by: Roger Quadros I also see other boards doing the wrong thing. i.e. replacing 'otg' with 'peripheral'. dra71-evm-u-boot.dtsi: dr_mode = "peripheral"; dra72-evm-revc-u-boot.dtsi: dr_mode = "peripheral"; dra72-evm-u-boot.dtsi: dr_mode = "peripheral"; dra76-evm-u-boot.dtsi: dr_mode = "peripheral"; dra7-evm-u-boot.dtsi: dr_mode = "peripheral"; k3-am642-evm-u-boot.dtsi: dr_mode="peripheral"; k3-am654-r5-base-board-u-boot.dtsi: dr_mode = "peripheral"; k3-am654-r5-base-board-u-boot.dtsi: dr_mode = "peripheral"; k3-j7200-common-proc-board-u-boot.dtsi: dr_mode = "peripheral"; k3-j721e-common-proc-board-u-boot.dtsi: dr_mode = "peripheral"; keystone-k2e-evm-u-boot.dtsi: dr_mode = "peripheral"; Is this something you can fix (in dwc3 driver) as it is on similar lines ;). Thanks! -- cheers, -roger