From: s.nawrocki@samsung.com (Sylwester Nawrocki) Date: Tue, 18 Nov 2014 16:19:49 +0100 Subject: [PATCH v5 2/2] ARM: EXYNOS: PMU: move restart code into pmu driver In-Reply-To: <1416307650-15162-3-git-send-email-pankaj.dubey@samsung.com> References: <1416307650-15162-1-git-send-email-pankaj.dubey@samsung.com> <1416307650-15162-3-git-send-email-pankaj.dubey@samsung.com> Message-ID: <546B6395.8020403@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 18/11/14 11:47, Pankaj Dubey wrote: > diff --git a/arch/arm/mach-exynos/pmu.c b/arch/arm/mach-exynos/pmu.c > index 6c8a76d..e4c3512 100644 > --- a/arch/arm/mach-exynos/pmu.c > +++ b/arch/arm/mach-exynos/pmu.c > @@ -11,8 +11,11 @@ > @@ -716,6 +719,13 @@ static void exynos5420_pmu_init(void) > pr_info("EXYNOS5420 PMU initialized\n"); > } > > +static int pmu_restart_notify(struct notifier_block *this, > + unsigned long code, void *unused) > +{ > + pmu_raw_writel(0x1, EXYNOS_SWRESET); Is it also valid on exynos5440 ? Doesn't it cause any harm there ? Perhaps we could add a comment saying it has not effect on that SoC ? > + return NOTIFY_DONE; > +} -- Thanks, Sylwester