Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 416F7C71155 for ; Wed, 2 Dec 2020 19:08:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC88E22259 for ; Wed, 2 Dec 2020 19:08:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729154AbgLBTHw (ORCPT ); Wed, 2 Dec 2020 14:07:52 -0500 Received: from mga06.intel.com ([134.134.136.31]:55028 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727454AbgLBTHw (ORCPT ); Wed, 2 Dec 2020 14:07:52 -0500 IronPort-SDR: RLJ7bJf8iDjuEYUWQCxdUD+BnGyAHQxk82A6bOH6qcCiChaQhjg817cn9mOLNHW5QxwkhMaiuA KPhdOJ/gCVfQ== X-IronPort-AV: E=McAfee;i="6000,8403,9823"; a="234677270" X-IronPort-AV: E=Sophos;i="5.78,387,1599548400"; d="scan'208";a="234677270" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2020 11:06:11 -0800 IronPort-SDR: E/sRQGC6KwsnS/HGSbtl1PBoK8VMw5qNMVAG4R921pvfite1KNduYVcLYKX/K2DONhdbAUhClu WvQoW0CTU7zw== X-IronPort-AV: E=Sophos;i="5.78,387,1599548400"; d="scan'208";a="316196419" Received: from icenteno-mobl1.amr.corp.intel.com ([10.251.24.90]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Dec 2020 11:06:11 -0800 Date: Wed, 2 Dec 2020 11:06:10 -0800 (PST) From: Mat Martineau To: Eric Dumazet cc: "David S . Miller" , Jakub Kicinski , netdev , Eric Dumazet , Paolo Abeni Subject: Re: [PATCH net-next] mptcp: avoid potential infinite loop in mptcp_recvmsg() In-Reply-To: <20201202171657.1185108-1-eric.dumazet@gmail.com> Message-ID: <547dd077-bcfc-cf42-9278-e388b3af1ac8@linux.intel.com> References: <20201202171657.1185108-1-eric.dumazet@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 2 Dec 2020, Eric Dumazet wrote: > From: Eric Dumazet > > If a packet is ready in receive queue, and application isssues > a recvmsg()/recvfrom()/recvmmsg() request asking for zero bytes, > we hang in mptcp_recvmsg(). > > Fixes: ea4ca586b16f ("mptcp: refine MPTCP-level ack scheduling") > Signed-off-by: Eric Dumazet > Cc: Paolo Abeni > --- > net/mptcp/protocol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Thanks for catching this Eric. Reviewed-by: Mat Martineau -- Mat Martineau Intel