From: David Vrabel Subject: Re: [Xen-devel] [PATCH] xen: fix sparse warning in p2m.c Date: Fri, 5 Dec 2014 10:43:12 +0000 Message-ID: <54818C40.5020706@citrix.com> References: <1417760195-16911-1-git-send-email-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1417760195-16911-1-git-send-email-jgross@suse.com> Sender: linux-kernel-owner@vger.kernel.org To: Juergen Gross , linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, konrad.wilk@oracle.com, david.vrabel@citrix.com, boris.ostrovsky@oracle.com List-Id: xen-devel@lists.xenproject.org On 05/12/14 06:16, Juergen Gross wrote: > The patch "Speed up set_phys_to_machine() by using read-only mappings" > introduced a sparse warning: > > arch/x86/xen/p2m.c:628:13: sparse: incorrect type in argument 1 > (different address spaces) > > Avoid the warning. Thanks. But can you add some helper functions instead? Perhaps: static inline int xen_safe_write_ulong(unsigned long *addr, unsigned long val) { //... } static inline int xen_safe_read_ulong(unsigned long *addr, unsigned long *val) { //... } David