From: Patrice CHOTARD Date: Tue, 3 Dec 2019 09:02:29 +0000 Subject: [U-Boot] [PATCH] cmd: pxe: execute the cls command only when supported In-Reply-To: <20191203083835.6898-1-patrick.delaunay@st.com> References: <20191203083835.6898-1-patrick.delaunay@st.com> Message-ID: <548341a1-9cea-40d4-a6e2-e84eb56d0366@st.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Patrick On 12/3/19 9:38 AM, Patrick Delaunay wrote: > Execute the command cls (for clear screen), when the "menu background" > keyword is present in extlinux.conf file, only if the command is supported. > > This patch avoid the warning "Unknown command 'cls'" > with "menu background" in extlinux.conf when CONFIG_CMD_BMP is activated > and CONFIG_CMD_CLS not activated (default for CONFIG_DM_VIDEO). > > Signed-off-by: Patrick Delaunay > --- > > cmd/pxe.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/cmd/pxe.c b/cmd/pxe.c > index 2059975446..b62cb79b3a 100644 > --- a/cmd/pxe.c > +++ b/cmd/pxe.c > @@ -1592,7 +1592,8 @@ static void handle_pxe_menu(cmd_tbl_t *cmdtp, struct pxe_menu *cfg) > /* display BMP if available */ > if (cfg->bmp) { > if (get_relfile(cmdtp, cfg->bmp, load_addr)) { > - run_command("cls", 0); > + if (CONFIG_IS_ENABLED(CMD_CLS)) > + run_command("cls", 0); > bmp_display(load_addr, > BMP_ALIGN_CENTER, BMP_ALIGN_CENTER); > } else { Reviewed-by: Patrice Chotard Thanks