From: Maarten Lankhorst Subject: Re: [PATCH 1/2] drm/i915: Unset legacy_cursor_update early in intel_atomic_commit, v3. Date: Tue, 19 Sep 2017 15:50:47 +0200 Message-ID: <549b6da0-a49d-a124-f309-4dee2e34fec3@linux.intel.com> References: <20170919121419.13708-1-maarten.lankhorst@linux.intel.com> <20170919133808.GT4914@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id D955D892DE for ; Tue, 19 Sep 2017 13:50:52 +0000 (UTC) In-Reply-To: <20170919133808.GT4914@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T3AgMTktMDktMTcgb20gMTU6Mzggc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6Cj4gT24gVHVlLCBT ZXAgMTksIDIwMTcgYXQgMDI6MTQ6MThQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6 Cj4+IENvbW1pdCBiNDRkNWMwYzEwNWEgKCJkcm0vaTkxNTogQWx3YXlzIHdhaXQgZm9yIGZsaXBf ZG9uZSwgdjIuIikgcmVtb3ZlZAo+PiB0aGUgY2FsbCB0byB3YWl0X2Zvcl92YmxhbmtzIGFuZCBy ZXBsYWNlZCBpdCB3aXRoIGZsaXBfZG9uZS4KPj4KPj4gVW5mb3J0dW5hdGVseSBsZWdhY3lfY3Vy c29yX3VwZGF0ZSB3YXMgdW5zZXQgdG9vIGxhdGUsIGFuZCB0aGUKPj4gcmVwbGFjZW1lbnQgY2Fs bCBkcm1fYXRvbWljX2hlbHBlcl93YWl0X2Zvcl9mbGlwX2RvbmUoKSB3YXMKPj4gYSBub29wLiBN YWtlIHN1cmUgdGhhdCBpdHMgdW5zZXQgYmVmb3JlIHNldHVwX2NvbW1pdCgpIGlzCj4+IGNhbGxl ZCB0byBmaXggdGhpcyBpc3N1ZS4KPj4KPj4gQ2hhbmdlcyBzaW5jZSB2MToKPj4gLSBGb3JjZSB2 Ymxhbmsgd2FpdCBmb3Igd2F0ZXJtYXJrcyBub3QgeWV0IGNvbnZlcnRlZCB0byBhdG9taWMgdG9v LiAoVmlsbGUpCj4+IC0gVXNlIGZvcl9lYWNoX25ld19pbnRlbF9jcnRjX2luX3N0YXRlLiAoVmls bGUpCj4+IENoYW5nZXMgc2luY2UgdjI6Cj4+IC0gTW92ZSB0aGUgb3B0aW1pemF0aW9uIHRvIGEg c2VwYXJhdGUgY29tbWl0LiAoVmlsbGUpCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFu a2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4+IEZpeGVzOiBiNDRk NWMwYzEwNWEgKCJkcm0vaTkxNTogQWx3YXlzIHdhaXQgZm9yIGZsaXBfZG9uZSwgdjIuIikKPj4g QnVnemlsbGE6IGh0dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTEw MjY3NQo+PiBUZXN0Y2FzZToga21zX2N1cnNvcl9jcmMKPj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRh bmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAbGlu dXguaW50ZWwuY29tPgo+PiBSZXBvcnRlZC1ieTogTWFydGEgTMO2ZnN0ZWR0IDxtYXJ0YS5sb2Zz dGVkdEBpbnRlbC5jb20+Cj4+IENjOiBNYXJ0YSBMw7Zmc3RlZHQgPG1hcnRhLmxvZnN0ZWR0QGlu dGVsLmNvbT4KPj4gVGVzdGVkLWJ5OiBNYXJ0YSBMw7Zmc3RlZHQgPG1hcnRhLmxvZnN0ZWR0QGlu dGVsLmNvbT4KPj4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRl bC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwg MzMgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tCj4+ICAxIGZpbGUgY2hhbmdlZCwg MTYgaW5zZXJ0aW9ucygrKSwgMTcgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPj4gaW5kZXggODU5OWU0MjVhYmIxLi5hODVjYTE5YTBjNDUgMTAwNjQ0 Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+PiArKysgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPj4gQEAgLTEyNTE3LDIxICsxMjUx NywxMCBAQCBzdGF0aWMgaW50IGludGVsX2F0b21pY19jb21taXQoc3RydWN0IGRybV9kZXZpY2Ug KmRldiwKPj4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRl dik7Cj4+ICAJaW50IHJldCA9IDA7Cj4+ICAKPj4gLQlyZXQgPSBkcm1fYXRvbWljX2hlbHBlcl9z ZXR1cF9jb21taXQoc3RhdGUsIG5vbmJsb2NrKTsKPj4gLQlpZiAocmV0KQo+PiAtCQlyZXR1cm4g cmV0Owo+PiAtCj4+ICAJZHJtX2F0b21pY19zdGF0ZV9nZXQoc3RhdGUpOwo+PiAgCWk5MTVfc3df ZmVuY2VfaW5pdCgmaW50ZWxfc3RhdGUtPmNvbW1pdF9yZWFkeSwKPj4gIAkJCSAgIGludGVsX2F0 b21pY19jb21taXRfcmVhZHkpOwo+PiAgCj4+IC0JcmV0ID0gaW50ZWxfYXRvbWljX3ByZXBhcmVf Y29tbWl0KGRldiwgc3RhdGUpOwo+PiAtCWlmIChyZXQpIHsKPj4gLQkJRFJNX0RFQlVHX0FUT01J QygiUHJlcGFyaW5nIHN0YXRlIGZhaWxlZCB3aXRoICVpXG4iLCByZXQpOwo+PiAtCQlpOTE1X3N3 X2ZlbmNlX2NvbW1pdCgmaW50ZWxfc3RhdGUtPmNvbW1pdF9yZWFkeSk7Cj4+IC0JCXJldHVybiBy ZXQ7Cj4+IC0JfQo+PiAtCj4+ICAJLyoKPj4gIAkgKiBUaGUgaW50ZWxfbGVnYWN5X2N1cnNvcl91 cGRhdGUoKSBmYXN0IHBhdGggdGFrZXMgY2FyZQo+PiAgCSAqIG9mIGF2b2lkaW5nIHRoZSB2Ymxh bmsgd2FpdHMgZm9yIHNpbXBsZSBjdXJzb3IKPj4gQEAgLTEyNTQwLDExICsxMjUyOSwxMSBAQCBz dGF0aWMgaW50IGludGVsX2F0b21pY19jb21taXQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPj4g IAkgKiB1cGRhdGVzIGhhcHBlbiBkdXJpbmcgdGhlIGNvcnJlY3QgZnJhbWVzLiBHZW45KyBoYXZl Cj4+ICAJICogZG91YmxlIGJ1ZmZlcmVkIHdhdGVybWFya3MgYW5kIHNvIHNob3VsZG4ndCBuZWVk IHRoaXMuCj4+ICAJICoKPj4gLQkgKiBEbyB0aGlzIGFmdGVyIGRybV9hdG9taWNfaGVscGVyX3Nl dHVwX2NvbW1pdCgpIGFuZAo+PiAtCSAqIGludGVsX2F0b21pY19wcmVwYXJlX2NvbW1pdCgpIGJl Y2F1c2Ugd2Ugc3RpbGwgd2FudAo+PiAtCSAqIHRvIHNraXAgdGhlIGZsaXAgYW5kIGZiIGNsZWFu dXAgd2FpdHMuIEFsdGhvdWdoIHRoYXQKPj4gLQkgKiBkb2VzIHJpc2sgeWFua2luZyB0aGUgbWFw cGluZyBmcm9tIHVuZGVyIHRoZSBkaXNwbGF5Cj4+IC0JICogZW5naW5lLgo+PiArCSAqIFVuc2V0 IHN0YXRlLT5sZWdhY3lfY3Vyc29yX3VwZGF0ZSBiZWZvcmUgdGhlIGNhbGwgdG8KPj4gKwkgKiBk cm1fYXRvbWljX2hlbHBlcl9zZXR1cF9jb21taXQoKSBiZWNhdXNlIG90aGVyd2lzZQo+PiArCSAq IGRybV9hdG9taWNfaGVscGVyX3dhaXRfZm9yX2ZsaXBfZG9uZSgpIGlzIGEgbm9vcCBhbmQKPj4g KwkgKiB3ZSBnZXQgRklGTyB1bmRlcnJ1bnMgYmVjYXVzZSB3ZSBkaWRuJ3Qgd2FpdAo+PiArCSAq IGZvciB2YmxhbmsuCj4+ICAJICoKPj4gIAkgKiBGSVhNRSBkb2luZyB3YXRlcm1hcmtzIGFuZCBm YiBjbGVhbnVwIGZyb20gYSB2Ymxhbmsgd29ya2VyCj4+ICAJICogKGFzc3VtaW5nIHdlIGhhZCBh bnkpIHdvdWxkIHNvbHZlIHRoZXNlIHByb2JsZW1zLgo+PiBAQCAtMTI1NTIsNyArMTI1NDEsMTcg QEAgc3RhdGljIGludCBpbnRlbF9hdG9taWNfY29tbWl0KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYs Cj4+ICAJaWYgKElOVEVMX0dFTihkZXZfcHJpdikgPCA5KQo+PiAgCQlzdGF0ZS0+bGVnYWN5X2N1 cnNvcl91cGRhdGUgPSBmYWxzZTsKPj4gIAo+PiAtCXJldCA9IGRybV9hdG9taWNfaGVscGVyX3N3 YXBfc3RhdGUoc3RhdGUsIHRydWUpOwo+PiArCXJldCA9IGludGVsX2F0b21pY19wcmVwYXJlX2Nv bW1pdChkZXYsIHN0YXRlKTsKPj4gKwlpZiAocmV0KSB7Cj4+ICsJCURSTV9ERUJVR19BVE9NSUMo IlByZXBhcmluZyBzdGF0ZSBmYWlsZWQgd2l0aCAlaVxuIiwgcmV0KTsKPj4gKwkJaTkxNV9zd19m ZW5jZV9jb21taXQoJmludGVsX3N0YXRlLT5jb21taXRfcmVhZHkpOwo+PiArCQlyZXR1cm4gcmV0 Owo+PiArCX0KPj4gKwo+PiArCXJldCA9IGRybV9hdG9taWNfaGVscGVyX3NldHVwX2NvbW1pdChz dGF0ZSwgbm9uYmxvY2spOwo+IEhtbS4gT25lIHRoaW5nIEkgbm90aWNlZCBoZXJlLiBQcmV2aW91 c2x5IGlmIHRoaXMgZmFpbGVkIHdlIGp1c3QgY2FsbGVkCj4gaTkxNV9zd19mZW5jZV9jb21taXQo KS4gTm93IHdlIHdpbGwgYWxzbyBjYWxsCj4gZHJtX2F0b21pY19oZWxwZXJfY2xlYW51cF9wbGFu ZXMoKS4gSXMgdGhhdCBnb2luZyB0byBiZSBhIHByb2JsZW0/ClRoaXMgaXMgaW50ZW50aW9uYWws IGludGVsX2F0b21pY19wcmVwYXJlX2NvbW1pdCBjYWxscyBwcmVwYXJlX3BsYW5lcywKaWYgdGhh dCBzdWNjZWVkcyB3ZSdsbCBuZWVkIHRvIGNhbGwgY2xlYW51cF9wbGFuZXMgdG9vLgoKT3JkZXJp bmcgb2Ygc2V0dXBfY29tbWl0IGFuZCBwcmVwYXJlX3BsYW5lcyBkb2Vzbid0IG1hdHRlci4KPj4g KwlpZiAoIXJldCkKPj4gKwkJcmV0ID0gZHJtX2F0b21pY19oZWxwZXJfc3dhcF9zdGF0ZShzdGF0 ZSwgdHJ1ZSk7Cj4+ICsKPj4gIAlpZiAocmV0KSB7Cj4+ICAJCWk5MTVfc3dfZmVuY2VfY29tbWl0 KCZpbnRlbF9zdGF0ZS0+Y29tbWl0X3JlYWR5KTsKPj4gIAo+PiAtLSAKPj4gMi4xNC4xCgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==