From: "Jan Beulich" Subject: Re: [PATCH 3/3] xen: use correct type for physical addresses Date: Fri, 09 Jan 2015 12:56:59 +0000 Message-ID: <54AFDE2B0200007800053248@mail.emea.novell.com> References: <1420736490-15351-1-git-send-email-jgross@suse.com> <1420736490-15351-4-git-send-email-jgross@suse.com> <54AFB410020000780005306E@mail.emea.novell.com> <54AFCED7.7040407@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Y9Z7e-0007Ci-2w for xen-devel@lists.xenproject.org; Fri, 09 Jan 2015 12:57:03 +0000 In-Reply-To: <54AFCED7.7040407@citrix.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: David Vrabel , Juergen Gross Cc: xen-devel , boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org >>> On 09.01.15 at 13:51, wrote: > On 09/01/15 09:57, Jan Beulich wrote: >>>>> On 08.01.15 at 18:01, wrote: >>> @@ -284,7 +286,7 @@ static void __init xen_update_mem_tables(unsigned long pfn, unsigned long mfn) >>> } >>> >>> /* Update kernel mapping, but not for highmem. */ >>> - if ((pfn << PAGE_SHIFT) >= __pa(high_memory)) >>> + if (PFN_PHYS(pfn) >= (u64)(__pa(high_memory))) >> >> I don't think you really need the cast on the right side - __pa() >> should be returning a value of suitable type (and unsigned long >> would be sufficient for anything up to and including high_memory). > > I'd prefer: > > if (pfn >= PFN_DOWN(__pa(high_memory)) Even better indeed. Just one more point: Strictly speaking __pa(high_memory) is invalid, as __pa() is defined for low memory only. Hence perhaps PFN_UP(__pa(high_memory - 1))? Jan