From: Oleksij Rempel Date: Sat, 24 Jan 2015 11:38:45 +0100 Subject: [ath9k-devel] [PATCH] ath9k and ath9k_htc: rename variable "led_blink" In-Reply-To: References: <1422094745-12718-1-git-send-email-hong@topbug.net> <87k30ciiir.fsf@kamboji.qca.qualcomm.com> Message-ID: <54C37635.6010708@rempel-privat.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org Am 24.01.2015 um 11:33 schrieb Sedat Dilek: > On Sat, Jan 24, 2015 at 11:23 AM, Kalle Valo wrote: >> Hong Xu writes: >> >>> ath9k and ath9k_htc use the variable name "led_blink" to indicate >>> whether the module parameter "blink" is on. This name is easy to >>> conflict with other variables, thus they are renamed. >> >> Please state clearly that this fixes a compiler error found by kbuild. >> Also it's very much recommended to add the actual compiler error to the >> commit log: >> >> drivers/net/wireless/ath/ath9k/ath9k_htc.o:(.data+0x47c): multiple definition of `led_blink' >> drivers/net/wireless/ath/ath9k/ath9k.o:(.bss+0x20): first defined here >> > > Some more things... > > If you post a vN (referring to your v3) of a patch, please add a > history of changes. What kind of history do you wont to have here? Kernel log should not be overloaded with patch preparation history. > 2nd, use the Fixes tag [2] in this case with a reference to the > culprit commit [1]. > > Fixes: 3a939a671225 ("ath9k_htc: Add a module parameter to disable blink") > > Last but not least, honour credits like Reported-by/Tested-by (plus > some infos like broken in Linux-next $VERSION). > > - Sedat - > > [1] http://git.kernel.org/cgit/linux/kernel/git/kvalo/wireless-drivers-next.git/commit/?id=3a939a671225909c19b09bfcb6e4761109e913d9 > [2] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/Documentation/SubmittingPatches#n159 > -- > To unsubscribe from this list: send the line "unsubscribe linux-wireless" in > the body of a message to majordomo at vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Regards, Oleksij -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 213 bytes Desc: OpenPGP digital signature Url : http://lists.ath9k.org/pipermail/ath9k-devel/attachments/20150124/7ab76d0c/attachment.pgp