Return-Path: Message-ID: <54C58A66.8070500@roeck-us.net> Date: Sun, 25 Jan 2015 16:29:26 -0800 From: Guenter Roeck MIME-Version: 1.0 To: Greg Kroah-Hartman CC: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hans Holmberg , Alexandre Courbot , Linus Walleij Subject: Re: [PATCH 3.10 25/50] gpiolib: of: Correct error handling in of_get_named_gpiod_flags References: <20150125180702.521559311@linuxfoundation.org> <20150125180703.970882239@linuxfoundation.org> <20150125213149.GA3313@roeck-us.net> <20150125220518.GA29924@kroah.com> In-Reply-To: <20150125220518.GA29924@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: On 01/25/2015 02:05 PM, Greg Kroah-Hartman wrote: > On Sun, Jan 25, 2015 at 01:31:49PM -0800, Guenter Roeck wrote: >> On Sun, Jan 25, 2015 at 10:07:15AM -0800, Greg Kroah-Hartman wrote: >>> 3.10-stable review patch. If anyone has any objections, please let me know. >>> >>> ------------------ >>> >>> From: Hans Holmberg >>> >>> commit 7b8792bbdffdff3abda704f89c6a45ea97afdc62 upstream. >>> >>> of_get_named_gpiod_flags fails with -EPROBE_DEFER in cases >>> where the gpio chip is available and the GPIO translation fails. >>> >>> This causes drivers to be re-probed erroneusly, and hides the >>> real problem(i.e. the GPIO number being out of range). >>> >>> Signed-off-by: Hans Holmberg >>> Reviewed-by: Alexandre Courbot >>> Signed-off-by: Linus Walleij >>> Signed-off-by: Greg Kroah-Hartman >>> >> >> This patch is causing several build failures. >> >> Error log: >> drivers/gpio/gpiolib-of.c: In function 'of_gpiochip_find_and_xlate': >> drivers/gpio/gpiolib-of.c:50:3: error: implicit declaration of function 'ERR_PTR' >> >> since "#include " is missing in drivers/gpio/gpiolib-of.c >> in the 3.10 kernel. > > Thanks for letting me know, I've pushed out a fix for this in the quilt > tree of patches. > Confirmed; build and qemu tests now pass with no errors. Guenter